jenkins-bot has submitted this change and it was merged.

Change subject: MenuLayout: Remove some redundant code
......................................................................


MenuLayout: Remove some redundant code

Calling this.updateSizes() at the end handles this.

Follow-up to I1c42fa4fa79efe023b3652717b3cb8545caeb01a.

Change-Id: I029ec6890a203dac0a2e75d26d478e67b93e252e
---
M src/layouts/MenuLayout.js
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/layouts/MenuLayout.js b/src/layouts/MenuLayout.js
index 80a4e6b..1d5ee3a 100644
--- a/src/layouts/MenuLayout.js
+++ b/src/layouts/MenuLayout.js
@@ -78,13 +78,11 @@
 
        // Initialization
        this.$menu
-               .addClass( 'oo-ui-menuLayout-menu' )
-               .css( this.menuPosition.sizeProperty, this.menuSize );
+               .addClass( 'oo-ui-menuLayout-menu' );
        this.$content.addClass( 'oo-ui-menuLayout-content' );
        this.$element
                .addClass( 'oo-ui-menuLayout ' + this.menuPosition.className )
                .append( this.$content, this.$menu );
-       this.toggleMenu( this.showMenu );
        this.updateSizes();
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/205298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I029ec6890a203dac0a2e75d26d478e67b93e252e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to