jenkins-bot has submitted this change and it was merged.
Change subject: Drop dead class properties, variables and methods
......................................................................
Drop dead class properties, variables and methods
Random snippets found by PHPStorms code analysis.
Change-Id: I100f02da376b59d82090f8bae8cef34e1ba03d8f
---
M client/tests/phpunit/includes/store/sql/BulkSubscriptionUpdaterTest.php
M repo/includes/LinkedData/EntityDataSerializationService.php
M view/src/EntityViewFactory.php
3 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/store/sql/BulkSubscriptionUpdaterTest.php
b/client/tests/phpunit/includes/store/sql/BulkSubscriptionUpdaterTest.php
index 635281b..743c754 100644
--- a/client/tests/phpunit/includes/store/sql/BulkSubscriptionUpdaterTest.php
+++ b/client/tests/phpunit/includes/store/sql/BulkSubscriptionUpdaterTest.php
@@ -210,7 +210,6 @@
foreach ( $entries as $entry ) {
list( $entityId, $pageId ) = $entry;
- $entityType = self::$entityTypeMap[ $entityId[0] ];
$aspect = 'X';
$db->insert( 'wbc_entity_usage', array(
diff --git a/repo/includes/LinkedData/EntityDataSerializationService.php
b/repo/includes/LinkedData/EntityDataSerializationService.php
index c751cc9..b1a6e0b 100644
--- a/repo/includes/LinkedData/EntityDataSerializationService.php
+++ b/repo/includes/LinkedData/EntityDataSerializationService.php
@@ -586,8 +586,6 @@
* @return ApiResult
*/
protected function generateApiResult( EntityRevision $entityRevision,
ApiFormatBase $printer ) {
- $entityKey = 'entity'; //XXX: perhaps better:
$entity->getType();
-
$res = $printer->getResult();
// Make sure result is empty. May still be full if this
diff --git a/view/src/EntityViewFactory.php b/view/src/EntityViewFactory.php
index 967e79e..49e1426 100644
--- a/view/src/EntityViewFactory.php
+++ b/view/src/EntityViewFactory.php
@@ -7,7 +7,6 @@
use Language;
use SiteStore;
use Wikibase\LanguageFallbackChain;
-use Wikibase\Lib\EntityIdFormatter;
use Wikibase\Lib\LanguageNameLookup;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\LabelDescriptionLookup;
@@ -239,15 +238,6 @@
$this->languageNameLookup,
$languageCode
);
- }
-
- /**
- * @param LabelDescriptionLookup $labelDescriptionLookup
- *
- * @return EntityIdFormatter
- */
- private function getPropertyIdFormatter( LabelDescriptionLookup
$labelDescriptionLookup ) {
- return $this->idFormatterFactory->getEntityIdFormater(
$labelDescriptionLookup );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/204474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I100f02da376b59d82090f8bae8cef34e1ba03d8f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
