Soeren.oldag has submitted this change and it was merged.
Change subject: add additional cases for dataMismatch to similarity checker
test and add @uses doc
......................................................................
add additional cases for dataMismatch to similarity checker test and add @uses
doc
Change-Id: I8de3ecb871f1644a71467c310e652bdfb9c3de06
---
M includes/CrossCheck/Comparer/SimilarityChecker.php
M tests/phpunit/Api/CrossCheckTest.php
M tests/phpunit/CrossCheck/Comparer/SimilarityCheckerTest.php
3 files changed, 42 insertions(+), 1 deletion(-)
Approvals:
Soeren.oldag: Verified; Looks good to me, approved
diff --git a/includes/CrossCheck/Comparer/SimilarityChecker.php
b/includes/CrossCheck/Comparer/SimilarityChecker.php
index b3810df..2314911 100755
--- a/includes/CrossCheck/Comparer/SimilarityChecker.php
+++ b/includes/CrossCheck/Comparer/SimilarityChecker.php
@@ -95,7 +95,6 @@
*/
private function percentagePostfixSimilarity( $localValue, $externalValue
){
$indexForLongestPostfixMatch = null;
- $percentageMatch = 0;
$postfixLength = 0; // common prefix length
$localLength = strlen( $localValue );
$externalLength = strlen( $externalValue );
diff --git a/tests/phpunit/Api/CrossCheckTest.php
b/tests/phpunit/Api/CrossCheckTest.php
old mode 100644
new mode 100755
index 6356b98..f6c1df4
--- a/tests/phpunit/Api/CrossCheckTest.php
+++ b/tests/phpunit/Api/CrossCheckTest.php
@@ -23,6 +23,7 @@
* @uses WikidataQuality\ExternalValidation\CrossCheck\ReferenceHandler
* @uses
WikidataQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparer
* @uses
WikidataQuality\ExternalValidation\CrossCheck\Comparer\StringValueComparer
+ * @uses
WikidataQuality\ExternalValidation\CrossCheck\Comparer\SimilarityChecker
* @uses WikidataQuality\ExternalValidation\CrossCheck\Result\CompareResult
* @uses WikidataQuality\ExternalValidation\CrossCheck\Result\ReferenceResult
* @uses
WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult
diff --git a/tests/phpunit/CrossCheck/Comparer/SimilarityCheckerTest.php
b/tests/phpunit/CrossCheck/Comparer/SimilarityCheckerTest.php
index 0a5d24e..64ec141 100755
--- a/tests/phpunit/CrossCheck/Comparer/SimilarityCheckerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/SimilarityCheckerTest.php
@@ -54,6 +54,21 @@
false
),
array(
+ array( 'fo' ),
+ array( 'foobar' ),
+ true
+ ),
+ array(
+ array( 'ar' ),
+ array( 'foobar' ),
+ true
+ ),
+ array(
+ array( 'foo' ),
+ array( 'baz' ),
+ true
+ ),
+ array(
array( 'foobar', 'fo' ),
array( 'foobar' ),
false
@@ -87,6 +102,23 @@
}
/**
+ * Test cases for testExecuteInvalidArguments
+ * @return array
+ */
+ public function constructInvalidArgumentsDataProvider() {
+ return array(
+ array(
+ 'foobar',
+ array( 'foobar' )
+ ),
+ array(
+ array( 'foobar' ),
+ 'foobar'
+ )
+ );
+ }
+
+ /**
* @dataProvider executeDataProvider
*/
public function testExecute( $localValues, $externalValues,
$expectedResult ) {
@@ -96,5 +128,14 @@
$this->assertEquals( $expectedResult, $result );
}
+ /**
+ * @dataProvider constructInvalidArgumentsDataProvider
+ */
+ public function testConstructInvalidArguments( $localValues,
$externalValues ) {
+ $this->setExpectedException( 'InvalidArgumentException' );
+
+ new SimilarityChecker( $localValues, $externalValues );
+ }
+
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/206114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8de3ecb871f1644a71467c310e652bdfb9c3de06
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Dominic.sauer <dominic.sa...@yahoo.de>
Gerrit-Reviewer: Soeren.oldag <soeren_ol...@freenet.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
