XZise has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206120
Change subject: [IMPROV] APISite: Faster validLanguageLinks
......................................................................
[IMPROV] APISite: Faster validLanguageLinks
Instead of a lookup in a list it's looking up in a set which doesn't
depend on it's length.
Change-Id: Ice7f51aef1673724c87ae2aa7a86f35f36d01692
---
M pywikibot/site.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/20/206120/1
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 62b8c4f..8fa7108 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -691,7 +691,7 @@
def validLanguageLinks(self):
"""Return list of language codes that can be used in interwiki
links."""
- nsnames = [name for name in self.namespaces().values()]
+ nsnames = set(itertools.chain(*self.namespaces().values()))
return [lang for lang in self.languages()
if first_upper(lang) not in nsnames]
--
To view, visit https://gerrit.wikimedia.org/r/206120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice7f51aef1673724c87ae2aa7a86f35f36d01692
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
