Trevor Parscal has submitted this change and it was merged. Change subject: (bug 42121) Change markers lost for first paragraph on new page ......................................................................
(bug 42121) Change markers lost for first paragraph on new page When editing a new page, or loading an empty page into the editor, the converter generates a paragraph so the document isn't completely empty. This paragraph is then unwrapped on the way out, potentially destroying change markers and generally producing strange HTML output. Mark this paragraph with generated=empty rather than generated=wrapper, and only unwrap it on the way out if it's still empty. This means we cleanly round-trip empty documents (and empty list items and the like), but if the user enters text, we create a paragraph like we're supposed to. Change-Id: Id0241221a67b769445676b833b5741320d99ea5f --- M modules/ve/dm/ve.dm.Converter.js M modules/ve/test/dm/ve.dm.Converter.test.js M modules/ve/test/dm/ve.dm.example.js 3 files changed, 58 insertions(+), 5 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33854 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0241221a67b769445676b833b5741320d99ea5f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
