Trevor Parscal has submitted this change and it was merged. Change subject: (bug 42212) Fix JS error when inserting after alien at the end ......................................................................
(bug 42212) Fix JS error when inserting after alien at the end TransactionProcessor was using parentOuterRange without checking whether it was present, so it was exploding for indexInNode results. Now checking for parentOuterRange presence, and falling back to nodeOuterRange when missing. This fix causes inconsistencies with zero-length text nodes. We should fix these eventually, but for now I've just made the unit tests tolerant of zero-length-text-node deviations. Change-Id: Id9eadd57a0d5fcbaf009c0781da0a03928aebb31 --- M modules/ve/dm/ve.dm.TransactionProcessor.js M modules/ve/test/dm/ve.dm.TransactionProcessor.test.js M modules/ve/test/ve.qunit.js 3 files changed, 39 insertions(+), 17 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9eadd57a0d5fcbaf009c0781da0a03928aebb31 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
