Alexandros Kosiaris has submitted this change and it was merged.
Change subject: service: Use a package require instead of a class
......................................................................
service: Use a package require instead of a class
The packages::<package_name> puppet class is an internal implementation
detail of require_packages and should not leak into puppet manifests. It
anyway creates the corresponding resource so rely on it for dependency
info.
Change-Id: I692da0fe642c77012a0f5a59d7ee94396ed40bc5
---
M modules/service/manifests/node.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/service/manifests/node.pp
b/modules/service/manifests/node.pp
index 6fd6aaa..8a965c0 100644
--- a/modules/service/manifests/node.pp
+++ b/modules/service/manifests/node.pp
@@ -141,7 +141,7 @@
provider => 'upstart',
require => [
Package["${title}/deploy"],
- Class['packages::nodejs_legacy']
+ Package['nodejs-legacy']
],
}
--
To view, visit https://gerrit.wikimedia.org/r/206363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I692da0fe642c77012a0f5a59d7ee94396ed40bc5
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
