Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206372
Change subject: Remove unused, undocumented 'entries' property from Factory
......................................................................
Remove unused, undocumented 'entries' property from Factory
Change-Id: Ifc68472fd29f51a412cb9b45b1264ffedca4571e
---
M src/Factory.js
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/72/206372/1
diff --git a/src/Factory.js b/src/Factory.js
index e9972ed..d23bcf6 100644
--- a/src/Factory.js
+++ b/src/Factory.js
@@ -7,9 +7,6 @@
oo.Factory = function OoFactory() {
// Parent constructor
oo.Factory.parent.call( this );
-
- // Properties
- this.entries = [];
};
/* Inheritance */
@@ -44,7 +41,6 @@
if ( typeof name !== 'string' || name === '' ) {
throw new Error( 'Name must be a string and must not be empty'
);
}
- this.entries.push( name );
// Parent method
oo.Factory.parent.prototype.register.call( this, name, constructor );
--
To view, visit https://gerrit.wikimedia.org/r/206372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc68472fd29f51a412cb9b45b1264ffedca4571e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
