Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206412
Change subject: Remove install-phpunit.sh
......................................................................
Remove install-phpunit.sh
The default fetch location is PEAR, which is not where PHPUnit
is distributed from anymore. apt-get and yum tend to ship horribly
outdated versions of PHPUnit that we don't want. Macports? Lol.
Instead one should install PHPUnit via composer. If you use vagrant
for testing, this is done for you. Our composer.json also lists
PHPUnit if you want to do it yourself.
Bug: T96834
Change-Id: I84ae186a9be2595cd594b428a07f3af684c258fe
---
M tests/phpunit/Makefile
D tests/phpunit/install-phpunit.sh
2 files changed, 1 insertion(+), 42 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/12/206412/1
diff --git a/tests/phpunit/Makefile b/tests/phpunit/Makefile
index 3f4c6f9..a33b86a 100644
--- a/tests/phpunit/Makefile
+++ b/tests/phpunit/Makefile
@@ -1,4 +1,4 @@
-.PHONY: help test phpunit install coverage warning destructive parser noparser
safe databaseless list-groups
+.PHONY: help test phpunit coverage warning destructive parser noparser safe
databaseless list-groups
.DEFAULT: warning
SHELL = /bin/sh
@@ -34,9 +34,6 @@
phpunit:
${PU}
-
-install:
- ./install-phpunit.sh
tap:
${PU} --tap
diff --git a/tests/phpunit/install-phpunit.sh b/tests/phpunit/install-phpunit.sh
deleted file mode 100755
index 022f998..0000000
--- a/tests/phpunit/install-phpunit.sh
+++ /dev/null
@@ -1,38 +0,0 @@
-#!/bin/sh
-
-has_binary () {
- if [ -z `which $1` ]; then
- return 1
- fi
- return 0
-}
-
-if [ `id -u` -ne 0 ]; then
- echo '*** ERROR: Must be root to run'
- exit 1
-fi
-
-if ( has_binary phpunit ); then
- echo PHPUnit already installed
-else if ( has_binary pear ); then
- echo Installing phpunit with pear
- pear channel-discover pear.phpunit.de
- pear channel-discover components.ez.no
- pear channel-discover pear.symfony.com
- pear update-channels
- #Temporary fix for 64597
- pear install --alldeps phpunit/PHPUnit-3.7.35
-else if ( has_binary apt-get ); then
- echo Installing phpunit with apt-get
- apt-get install phpunit
-else if ( has_binary yum ); then
- echo Installing phpunit with yum
- yum install phpunit
-else if ( has_binary port ); then
- echo Installing phpunit with macports
- port install php5-unit
-fi
-fi
-fi
-fi
-fi
--
To view, visit https://gerrit.wikimedia.org/r/206412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84ae186a9be2595cd594b428a07f3af684c258fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
