jenkins-bot has submitted this change and it was merged.
Change subject: The title can be null for internal API requests.
......................................................................
The title can be null for internal API requests.
See also T92875#1233108 re external API requests.
Fixes T97104
Bug: T97104
Bug: T92875
Change-Id: Iea401983ed7e5202cccb4b9c0bc18b2803d1f386
---
M WikimediaEventsHooks.php
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 5d02356..e777996 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -40,10 +40,12 @@
*/
public static function onXAnalyticsHeader( $out, &$headerItems ) {
$title = $out->getTitle();
- $pageId = $title->getArticleId();
- if ( is_int( $pageId ) && $pageId > 0 ) {
- $headerItems['page_id'] = $pageId;
- $headerItems['ns'] = $title->getNamespace();
+ if ( $title !== null ) {
+ $pageId = $title->getArticleId();
+ if ( is_int( $pageId ) && $pageId > 0 ) {
+ $headerItems['page_id'] = $pageId;
+ $headerItems['ns'] = $title->getNamespace();
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/206352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea401983ed7e5202cccb4b9c0bc18b2803d1f386
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
