jenkins-bot has submitted this change and it was merged.
Change subject: Fix category column count regression
......................................................................
Fix category column count regression
T55130 redesigned category view to use dynamic CSS-based columns
instead of the old fixed 3-column layout. The design was updated
in I20b68dea8f, setting the column width to 25em.
However, on 1280px screen, this reduces the layout to just 2 columns,
as 3 columns do not fit: With the default 14px font, 25em translates
to 350px of column width, plus 1em of column-gap, therefore, 1078px
of space would be required for three columns. However, a 1280px
screen seems to have only 1038px left for content, so 40px are
missing.
By reducing the column size slightly to 24em, three columns are back.
Bug: T55130
Change-Id: I2dbecf809c54d786579bdf3826efbf85ad822c7c
(cherry picked from commit 7a4cce3fde69512ae17877b20afd464b64ffd3e3)
---
M resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
b/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
index f01115b..387b020 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
+++ b/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
@@ -2,7 +2,7 @@
.mw-category {
.column-count(3);
- .column-width(25em);
+ .column-width(24em);
.mw-category-group {
li {
.column-break-inside-avoid;
--
To view, visit https://gerrit.wikimedia.org/r/206419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dbecf809c54d786579bdf3826efbf85ad822c7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_25
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Mormegil <morme...@centrum.cz>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
