Mhurd has submitted this change and it was merged.
Change subject: Fix logic in testing code - wasn't using the passed in
parameter and the unit test was failing and broke the build
......................................................................
Fix logic in testing code - wasn't using the passed in parameter and the unit
test was failing and broke the build
Change-Id: I854eb433ec117f3cadae1ee49e534f8f73f2f882
---
M WikipediaUnitTests/Utilities/NSBundle+TestAssets.m
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mhurd: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikipediaUnitTests/Utilities/NSBundle+TestAssets.m
b/WikipediaUnitTests/Utilities/NSBundle+TestAssets.m
index e5d0c0a..2ef5dce 100644
--- a/WikipediaUnitTests/Utilities/NSBundle+TestAssets.m
+++ b/WikipediaUnitTests/Utilities/NSBundle+TestAssets.m
@@ -12,7 +12,7 @@
- (NSData*)wmf_dataFromContentsOfFile:(NSString *)filename ofType:(NSString
*)type {
NSError* error;
- NSData* data = [NSData dataWithContentsOfFile:[self
pathForResource:filename ofType:@"json"]
+ NSData* data = [NSData dataWithContentsOfFile:[self
pathForResource:filename ofType:type]
options:0
error:&error];
NSParameterAssert(!error);
--
To view, visit https://gerrit.wikimedia.org/r/206472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I854eb433ec117f3cadae1ee49e534f8f73f2f882
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
