Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/206756

Change subject: Use new passCaptchaLimited() instead of passCaptcha()
......................................................................

Use new passCaptchaLimited() instead of passCaptcha()

Make sure, that Flow is covered by ConfirmEdit's badcaptcha ratelimiter.

Depends on: I46563068c7c0ebe1747d5e24457ca6ccd3a09325

Change-Id: I0b3388728cfbc5ceff93c7ebc54071f736ae929d
---
M includes/SpamFilter/ConfirmEdit.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/56/206756/1

diff --git a/includes/SpamFilter/ConfirmEdit.php 
b/includes/SpamFilter/ConfirmEdit.php
index 89baa3e..98026eb 100644
--- a/includes/SpamFilter/ConfirmEdit.php
+++ b/includes/SpamFilter/ConfirmEdit.php
@@ -29,7 +29,7 @@
 
                // first check if the submitted content is offensive (as 
flagged by
                // ConfirmEdit), next check for a (valid) captcha to have been 
entered
-               if ( $captcha->shouldCheck( $wikiPage, $newContent, false, 
false, $oldContent ) && !$captcha->passCaptcha() ) {
+               if ( $captcha->shouldCheck( $wikiPage, $newContent, false, 
false, $oldContent ) && !$captcha->passCaptchaLimited() ) {
                        // getting here means we submitted bad content without 
good captcha
                        // result (or any captcha result at all) - let's get 
the captcha
                        // HTML to display as error message!

-- 
To view, visit https://gerrit.wikimedia.org/r/206756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b3388728cfbc5ceff93c7ebc54071f736ae929d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to