jenkins-bot has submitted this change and it was merged.
Change subject: i18n: Tweaks
......................................................................
i18n: Tweaks
* Gender support for various messages
* Reference to edit button.
Bug: T95547
Change-Id: Id1bd4e0d2780c63285d3b1b1a7685392ec9ab382
---
M i18n/en.json
M i18n/qqq.json
M includes/views/Collection.php
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 5f2c401..d6e9b86 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -65,7 +65,7 @@
"gather-new-collection-failed-toast": "There was a problem creating
your \"$1\" collection.",
"gather-add-failed-toast": "There was a problem adding the item to your
\"$1\" collection.",
"gather-add-title-invalid-toast": "There was an issue with the title
you entered. Please try something else",
- "gather-add-to-collection-summary": "Add $1 to a collection of pages
you can share with the world!",
+ "gather-add-to-collection-summary": "{{GENDER:$2|Add}} $1 to a
collection of pages you can share with the world!",
"gather-add-to-collection-confirm": "Add to collection",
"gather-add-to-collection-cancel": "No thanks",
"gather-update-collection-success": "Collection was successfully
updated.",
@@ -82,7 +82,7 @@
"gather-watchlist-description": "A list of pages that I am interested
in.",
"gather-lists-title": "Collections",
"gather-lists-from-user-title": "Collections by $1",
- "gather-meta-description": "Here are the collections $1 has created on
{{SITENAME}}.",
+ "gather-meta-description": "Here are the collections $1 {{GENDER:$1|has
created}} on {{SITENAME}}.",
"gather-read-more": "Read more",
"gather-private": "Private",
"gather-public": "Public",
@@ -97,7 +97,7 @@
"gather-echo-pref-tooltip": "Notify me about changes to my
collections.",
"gather-article-count": "$1 {{PLURAL:$1|page|pages}}",
"gather-empty": "Nothing in this collection yet...",
- "gather-empty-footer-mine": "Add pages to this collection by clicking
the edit button.",
+ "gather-empty-footer-mine": "{{GENDER:$1|Add}} pages to this collection
by clicking the \"{{int:gather-edit-button}}\" button.",
"gather-empty-footer": "This is an empty collection.",
"gather-edit-button": "Edit",
"gather-delete-button": "Delete",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 37ee8d5..4311852 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -69,7 +69,7 @@
"gather-new-collection-failed-toast": "Message displayed when creating
a new collection fails. Parameters:\n* $1 - Name of collection.",
"gather-add-failed-toast": "Message displayed when adding an item to a
collection fails. Parameters:\n* $1 - Name of collection.",
"gather-add-title-invalid-toast": "Message displayed to a user when
editing or creating a collection fails because of an invalid title.",
- "gather-add-to-collection-summary": "Text for a tutorial overlay
presented to a user the first time they see the collections watchstar asking
them if they would like to add the current page to a
collection.\n\nParameters:\n* $1 - page title",
+ "gather-add-to-collection-summary": "Text for a tutorial overlay
presented to a user the first time they see the collections watchstar asking
them if they would like to add the current page to a
collection.\n\nParameters:\n* $1 - page title\n* $2 - currently logged in
username for use in gender",
"gather-add-to-collection-confirm": "Label for button that user can
click if they would like to add the current page to a collection",
"gather-add-to-collection-cancel": "Label for button that user can
click if they do not want to add to a collection.\n{{Identical|No thanks}}",
"gather-update-collection-success": "Message that shows when collection
description and/or title changed.",
@@ -99,7 +99,7 @@
"gather-echo-pref-tooltip": "This is a short description of the gather
notification category.\n{{Related|Echo-pref-tooltip}}",
"gather-article-count": "Expression of the number of pages in a
collection. Parameter:\n* $1 - number of pages in the
collection\n{{Identical|Page}}",
"gather-empty": "Message shown on an empty rendered collection on
[[Special:Gather]].",
- "gather-empty-footer-mine": "Footnote shown on an empty collection on
[[Special:Gather]] when the collection belongs to them.",
+ "gather-empty-footer-mine": "Footnote shown on an empty collection on
[[Special:Gather]] when the collection belongs to them.\nParameters:\n* $1 -
username of current user for use in gender.",
"gather-empty-footer": "Footnote shown on an empty collection on
[[Special:Gather]] for a collection that doesn't belong to them.",
"gather-edit-button": "Label for a button that enables editing a
collection.\n{{Identical|Edit}}",
"gather-delete-button": "Label for a button that enables deleting a
collection.\n{{Identical|Delete}}",
diff --git a/includes/views/Collection.php b/includes/views/Collection.php
index 9b2e381..e088082 100644
--- a/includes/views/Collection.php
+++ b/includes/views/Collection.php
@@ -130,7 +130,7 @@
return Html::openElement( 'div', array( 'class' =>
'collection-empty' ) ) .
Html::element( 'h3', array(), wfMessage( 'gather-empty'
)->text() ) .
Html::element( 'div', array(),
- wfMessage( $key )->text() ) .
+ wfMessage( $key, $user->getName() )->text() ) .
Html::closeElement( 'div' );
}
--
To view, visit https://gerrit.wikimedia.org/r/205801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1bd4e0d2780c63285d3b1b1a7685392ec9ab382
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
