Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206951
Change subject: Don't skip slug contents in getNodeAndOffset()
......................................................................
Don't skip slug contents in getNodeAndOffset()
Now that users can type content directly into inline
slugs and we're no longer pawning there, text inside
of inline slugs should be counted.
Change-Id: I85c4d9069814b4e958c6e3086b4a3c70d7fe1d60
---
M src/ce/ve.ce.Document.js
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/51/206951/1
diff --git a/src/ce/ve.ce.Document.js b/src/ce/ve.ce.Document.js
index 90b6050..aac942b 100644
--- a/src/ce/ve.ce.Document.js
+++ b/src/ce/ve.ce.Document.js
@@ -228,10 +228,6 @@
startOffset += length;
}
}
- } else if ( $item.hasClass( 've-ce-branchNode-slug' ) )
{
- // Skip contents without incrementing offset
- current[1]++;
- continue;
} else {
stack.push( [$item.contents(), 0] );
current[1]++;
--
To view, visit https://gerrit.wikimedia.org/r/206951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85c4d9069814b4e958c6e3086b4a3c70d7fe1d60
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
