jenkins-bot has submitted this change and it was merged.
Change subject: Hover on the post action menu instead of clicking on it
......................................................................
Hover on the post action menu instead of clicking on it
Bug: T94153
Change-Id: I6d004001af2f37d82169c585f4b23adcca7ad7d7
---
M tests/browser/features/action_menu_permalink.feature
M tests/browser/features/flow_logged_in.feature
M tests/browser/features/lock_unlock_topics.feature
M tests/browser/features/moderation.feature
M tests/browser/features/step_definitions/flow_steps.rb
M tests/browser/features/step_definitions/lock_unlock_topics_steps.rb
6 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/action_menu_permalink.feature
b/tests/browser/features/action_menu_permalink.feature
index 00a4085..cdeac63 100644
--- a/tests/browser/features/action_menu_permalink.feature
+++ b/tests/browser/features/action_menu_permalink.feature
@@ -7,7 +7,7 @@
Scenario: Topic Actions menu Permalink
Given I have created a Flow topic with title "Permalinktest"
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click Permalink from the Actions menu
And I am viewing Topic page
Then I see only one topic on the page
diff --git a/tests/browser/features/flow_logged_in.feature
b/tests/browser/features/flow_logged_in.feature
index 38580fc..73e9d00 100644
--- a/tests/browser/features/flow_logged_in.feature
+++ b/tests/browser/features/flow_logged_in.feature
@@ -27,7 +27,7 @@
And I should see a Suppress button
Scenario: Topic Actions
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
Then I should see a Hide topic button
And I should see a Delete topic button
And I should see a Suppress topic button
diff --git a/tests/browser/features/lock_unlock_topics.feature
b/tests/browser/features/lock_unlock_topics.feature
index 062c304..83ab1a4 100644
--- a/tests/browser/features/lock_unlock_topics.feature
+++ b/tests/browser/features/lock_unlock_topics.feature
@@ -17,7 +17,7 @@
Scenario: Locking a topic and then changing your mind
Given I am on Flow page
And I have created a Flow topic
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Lock topic button
And I cancel the lock/unlock topic form
Then the top post should be an open discussion
@@ -27,7 +27,7 @@
Scenario: Locking a topic
Given I am on Flow page
And I have created a Flow topic
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Lock topic button
And I type "This is a bikeshed" as the reason
And I submit the lock/unlock topic form
@@ -40,7 +40,7 @@
Given I am on Flow page
And I have created a Flow topic
And the top post has been locked
- And I click the Topic Actions link
+ And I hover on the Topic Actions link
And I click the Unlock topic button
When I type "Fun discussion" as the reason
And I submit the lock/unlock topic form
diff --git a/tests/browser/features/moderation.feature
b/tests/browser/features/moderation.feature
index 3fa1441..7718e1a 100644
--- a/tests/browser/features/moderation.feature
+++ b/tests/browser/features/moderation.feature
@@ -9,7 +9,7 @@
Scenario: Deleting a topic
Given I have created a Flow topic with title "Deletemeifyoudare"
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Delete topic button
And I see a dialog box
And I give reason for deletion as being "He's a naughty boy"
@@ -18,7 +18,7 @@
Scenario: Suppressing a topic
Given I have created a Flow topic with title "Suppressmeifyoudare"
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Suppress topic button
And I see a dialog box
And I give reason for suppression as being "Quelling the peasants"
@@ -27,7 +27,7 @@
Scenario: Cancelling a dialog without text
Given I have created a Flow topic with title "Testing cancel deletion of
topic"
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Delete topic button
And I see a dialog box
And I cancel the dialog
@@ -35,7 +35,7 @@
Scenario: Cancelling a dialog with text
Given I have created a Flow topic with title "Testing cancel deletion of
topic"
- When I click the Topic Actions link
+ When I hover on the Topic Actions link
And I click the Delete topic button
And I see a dialog box
And I give reason for suppression as being "About to change my mind"
diff --git a/tests/browser/features/step_definitions/flow_steps.rb
b/tests/browser/features/step_definitions/flow_steps.rb
index 76d7470..aca75dc 100644
--- a/tests/browser/features/step_definitions/flow_steps.rb
+++ b/tests/browser/features/step_definitions/flow_steps.rb
@@ -69,8 +69,8 @@
on(FlowPage).topic_suppress_button_element.when_present.click
end
-When(/^I click the Topic Actions link$/) do
- on(FlowPage).topic_actions_link_element.when_present.click
+When(/^I hover on the Topic Actions link$/) do
+ on(FlowPage).topic_actions_link_element.when_present.hover
end
When(/^I hover over the author link$/) do
diff --git
a/tests/browser/features/step_definitions/lock_unlock_topics_steps.rb
b/tests/browser/features/step_definitions/lock_unlock_topics_steps.rb
index 787170f..fd749bc 100644
--- a/tests/browser/features/step_definitions/lock_unlock_topics_steps.rb
+++ b/tests/browser/features/step_definitions/lock_unlock_topics_steps.rb
@@ -13,7 +13,7 @@
end
Given(/^the top post has been locked$/) do
- step 'I click the Topic Actions link'
+ step 'I hover on the Topic Actions link'
step 'I click the Lock topic button'
step 'I type "This is a bikeshed" as the reason'
step 'I submit the lock/unlock topic form'
--
To view, visit https://gerrit.wikimedia.org/r/206880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d004001af2f37d82169c585f4b23adcca7ad7d7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
