Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207011
Change subject: Hygiene: Remove the 'options' argument from preRender and
postRender functions
......................................................................
Hygiene: Remove the 'options' argument from preRender and postRender functions
Depends on If8fc6b5223868ffd180b08ec931f6ca82e2223d5
Change-Id: I4598a5009ab3f189dd37603f7ed8021c07070dcf
---
M resources/dialog.c/WikiGrokDialogC.js
M resources/dialog/WikiGrokDialog.js
M resources/roulette/ErrorDrawer.js
3 files changed, 9 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok
refs/changes/11/207011/1
diff --git a/resources/dialog.c/WikiGrokDialogC.js
b/resources/dialog.c/WikiGrokDialogC.js
index 2518a91..6a4c5ce 100644
--- a/resources/dialog.c/WikiGrokDialogC.js
+++ b/resources/dialog.c/WikiGrokDialogC.js
@@ -91,16 +91,16 @@
/**
* @inheritdoc
*/
- postRender: function ( options ) {
+ postRender: function () {
var self = this;
- Drawer.prototype.postRender.apply( this, arguments );
+ Drawer.prototype.postRender.apply( this );
// Don't run this when rendering the Badge template
- if ( !options.beginQuestions ) {
- options.beginQuestions = true;
+ if ( !this.options.beginQuestions ) {
+ this.options.beginQuestions = true;
- self.askWikidataQuestion( options );
+ self.askWikidataQuestion( this.options );
// Silently fetch the next page
wikiGrokRoulette.getNextPage();
diff --git a/resources/dialog/WikiGrokDialog.js
b/resources/dialog/WikiGrokDialog.js
index 5c62d96..e1ba990 100644
--- a/resources/dialog/WikiGrokDialog.js
+++ b/resources/dialog/WikiGrokDialog.js
@@ -438,12 +438,10 @@
/**
* @inheritdoc
*/
- postRender: function ( options ) {
- if ( options.campaign && !options.beginQuestions ) {
-
+ postRender: function () {
+ if ( this.options.campaign &&
!this.options.beginQuestions ) {
// Show the intro pane once.
- options.beginQuestions = true;
-
+ this.options.beginQuestions = true;
this._showIntroPane();
}
},
diff --git a/resources/roulette/ErrorDrawer.js
b/resources/roulette/ErrorDrawer.js
index 5721314..c513ea5 100644
--- a/resources/roulette/ErrorDrawer.js
+++ b/resources/roulette/ErrorDrawer.js
@@ -25,7 +25,7 @@
*/
postRender: function () {
var self = this;
- Drawer.prototype.postRender.apply( this, arguments );
+ Drawer.prototype.postRender.apply( this );
this.$el.find( '.close' ).on( 'click', function () {
self.detach();
} );
--
To view, visit https://gerrit.wikimedia.org/r/207011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4598a5009ab3f189dd37603f7ed8021c07070dcf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
