jenkins-bot has submitted this change and it was merged.

Change subject: Don't retry if we're err'ing out
......................................................................


Don't retry if we're err'ing out

 * Maybe throwing here would be better.

Change-Id: Ifa4d2341c5b032dbf019b623f0f6b73c91469cf8
---
M lib/mediawiki.ApiRequest.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Subramanya Sastry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/mediawiki.ApiRequest.js b/lib/mediawiki.ApiRequest.js
index 659c420..1de1b54 100644
--- a/lib/mediawiki.ApiRequest.js
+++ b/lib/mediawiki.ApiRequest.js
@@ -752,6 +752,7 @@
        this.reqType = "Config Request";
 
        if (!uri) {
+               this.retries = 0;
                this._requestCB(new Error('There was no base URI for the API we 
tried to use.'));
                return;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/206483
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa4d2341c5b032dbf019b623f0f6b73c91469cf8
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to