Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/207333

Change subject: labs_lvm: remove quoting around -t param to mkfs
......................................................................

labs_lvm: remove quoting around -t param to mkfs

Otherwise mkfs.'ext4' is the executable it tries to invoke

Change-Id: Ib9b9132c9abbce86b76d9587c8f9ac93e5f8047e
---
M modules/labs_lvm/files/make-instance-vol
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/33/207333/1

diff --git a/modules/labs_lvm/files/make-instance-vol 
b/modules/labs_lvm/files/make-instance-vol
index c13b8ec..e27b60d 100755
--- a/modules/labs_lvm/files/make-instance-vol
+++ b/modules/labs_lvm/files/make-instance-vol
@@ -10,7 +10,7 @@
 fi
 
 if /sbin/lvcreate $sopt -n "$name" vd; then
-  makefs="/sbin/mkfs -t '$fstype'"
+  makefs="/sbin/mkfs -t $fstype"
   if [ "x$fstype" = "xswap" ]; then
     makefs="/sbin/mkswap"
   fi

-- 
To view, visit https://gerrit.wikimedia.org/r/207333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b9132c9abbce86b76d9587c8f9ac93e5f8047e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to