jenkins-bot has submitted this change and it was merged.
Change subject: Avoid requesting unused information from API in NearbyFetchTask
......................................................................
Avoid requesting unused information from API in NearbyFetchTask
NearbyFetchTask currently requests a pageimage property that it doesn't use.
This changes NearbyFetchTask to explicitly not request that property, which
will slightly reduce data usage for the user with no UI changes.
Change-Id: I92a758975915e50f0c02e998161ff2e5a014d4b5
Task: T97276
---
M wikipedia/src/main/java/org/wikipedia/nearby/NearbyFetchTask.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFetchTask.java
b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFetchTask.java
index 30bc6d8..0ec8cac 100644
--- a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFetchTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFetchTask.java
@@ -40,6 +40,7 @@
return api.action("query")
.param("prop", "coordinates|pageimages|pageterms")
.param("colimit", LIMIT)
+ .param("piprop", "thumbnail") // so response doesn't contain
unused "pageimage" prop
.param("pithumbsize", THUMBNAIL_WIDTH)
.param("pilimit", LIMIT)
.param("wbptterms", "description")
--
To view, visit https://gerrit.wikimedia.org/r/207030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92a758975915e50f0c02e998161ff2e5a014d4b5
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
