Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207486
Change subject: LocalPageMoveJob: Don't overwrite existing pages
......................................................................
LocalPageMoveJob: Don't overwrite existing pages
Bug: T97536
Change-Id: Icac3e87ad05c4cd1ab640b99a04e94d760a4ca6f
---
M includes/LocalRenameJob/LocalPageMoveJob.php
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/86/207486/1
diff --git a/includes/LocalRenameJob/LocalPageMoveJob.php
b/includes/LocalRenameJob/LocalPageMoveJob.php
index 632f963..c4f1f86 100644
--- a/includes/LocalRenameJob/LocalPageMoveJob.php
+++ b/includes/LocalRenameJob/LocalPageMoveJob.php
@@ -41,6 +41,12 @@
wfDebugLog( 'CentralAuthRename', "Invalid page move:
{$oldPage->getPrefixedText()} -> {$newPage->getPrefixedText()}" );
return;
}
+ // @todo should this check be in MovePage instead?
+ if ( $newPage->getArticleID( Title::GAID_FOR_UPDATE ) ) {
+ // Don't overwrite an existing page, bug T97536
+ wfDebugLog( 'CentralAuthRename', "Target page exists:
{$oldPage->getPrefixedText()} -> {$newPage->getPrefixedText()}" );
+ return;
+ }
$msg = wfMessage( 'centralauth-rename-movelog' )
->params( $this->params['from'], $this->params['to'] )
--
To view, visit https://gerrit.wikimedia.org/r/207486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icac3e87ad05c4cd1ab640b99a04e94d760a4ca6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
