[MediaWiki-commits] [Gerrit] Fix toolbar & debug bar negative margins - change (mediawiki...VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/207765

Change subject: Fix toolbar & debug bar negative margins
......................................................................

Fix toolbar & debug bar negative margins

Now 0.8em is set on the target wrapper, divide all these
margins by 0.8.

Change-Id: If373eac4d2abb9f58da816163b27e4110c39a213
---
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css
2 files changed, 15 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/65/207765/1

diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css 
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
index b7214ff..2eb5495 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
@@ -23,7 +23,8 @@
 }
 
 .ve-init-mw-viewPageTarget-toolbar {
-       margin: -0.6em -0.8em 1em -0.8em;
+       /* 0.6/0.8, 0.8/0.8, 1/0.6 */
+       margin: -0.75em -1em 1.25em -1em;
 }
 
 .ve-init-target > .ve-ui-debugBar {
@@ -35,8 +36,9 @@
 }
 
 .ve-init-target > .ve-ui-debugBar {
-       padding: 0.8em;
-       margin: 0.8em -0.8em -0.8em -0.8em;
+       /* 0.8/0.8 */
+       padding: 1em;
+       margin: 1em -1em -1em -1em;
 }
 
 .ve-ui-overlay-global {
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css 
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css
index 099bf14..848888a 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css
@@ -35,7 +35,8 @@
 }
 
 .ve-init-mw-viewPageTarget-toolbar {
-       margin: -1em -1em 1em -1em;
+       /* 1/0.8 */
+       margin: -1.25em -1.25em 1.25em -1.25em;
        position: relative;
        border-bottom: 1px solid rgba(0,0,0,0.15);
 }
@@ -48,8 +49,9 @@
 }
 
 .ve-init-target > .ve-ui-debugBar {
-       padding: 1em;
-       margin: 1em -1em -1em -1em;
+       /* 1/0.8 */
+       padding: 1.25em;
+       margin: 1.25em -1.25em -1.25em -1.25em;
 }
 
 .ve-ui-debugBar {
@@ -96,12 +98,14 @@
        }
 
        .ve-init-mw-viewPageTarget-toolbar {
-               margin: -1.25em -1.5em 1.5em -1.5em;
+               /* 1.25/0.8, 1.5/0.8 */
+               margin: -1.5625em -1.875em 1.875em -1.875em;
        }
 
        .ve-init-target > .ve-ui-debugBar {
-               padding: 1.5em;
-               margin: 1em -1.5em -1.5em -1.5em;
+               /* 1/0.8, 1.5/0.8 */
+               padding: 1.875em;
+               margin: 1.25em -1.875em -1.875em -1.875em;
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/207765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If373eac4d2abb9f58da816163b27e4110c39a213
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits