jenkins-bot has submitted this change and it was merged.

Change subject: Preferences: Use case-insensitive comparison for skin names
......................................................................


Preferences: Use case-insensitive comparison for skin names

They are treated case-insensitively everywhere else.

Change-Id: I2561150aca9d88ad67ef359143f06d0ee90ab52e
---
M includes/Preferences.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Preferences.php b/includes/Preferences.php
index 74a917d..9b0ada8 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1098,7 +1098,7 @@
                        $linkTools = array();
 
                        # Mark the default skin
-                       if ( $skinkey == $defaultSkin ) {
+                       if ( strcasecmp( $skinkey, $defaultSkin ) === 0 ) {
                                $linkTools[] = $context->msg( 'default' 
)->escaped();
                                $foundDefault = true;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/206971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2561150aca9d88ad67ef359143f06d0ee90ab52e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to