Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/208125
Change subject: Only replace queryMap if the prehandler returns it ...................................................................... Only replace queryMap if the prehandler returns it Bug T97749 Change-Id: Ia40bb7b2ba36fd6cfb0ca04533214becad7e2ad1 --- M modules/engine/components/common/flow-component-events.js 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/25/208125/1 diff --git a/modules/engine/components/common/flow-component-events.js b/modules/engine/components/common/flow-component-events.js index 37d3620..b7e3448 100644 --- a/modules/engine/components/common/flow-component-events.js +++ b/modules/engine/components/common/flow-component-events.js @@ -906,8 +906,10 @@ return $.Deferred().reject( 'fail-prehandler', { error: { info: 'apiPreHandler returned false' } } ); } - // update changed queryMap - args.splice( 2, 0, queryMap ); + if ( $.isPlainObject( queryMap ) ) { + args[2] = queryMap; + } + return args; }; } ); -- To view, visit https://gerrit.wikimedia.org/r/208125 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia40bb7b2ba36fd6cfb0ca04533214becad7e2ad1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits