Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208129
Change subject: Remove commented out code
......................................................................
Remove commented out code
FYI: we are actually using a VCS here
Change-Id: I1295afc3af0c855ae0eac33cf73e1dd30ce83fa0
---
M purtle/src/N3RdfWriterBase.php
1 file changed, 0 insertions(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/208129/1
diff --git a/purtle/src/N3RdfWriterBase.php b/purtle/src/N3RdfWriterBase.php
index ea405d7..23aa8b4 100644
--- a/purtle/src/N3RdfWriterBase.php
+++ b/purtle/src/N3RdfWriterBase.php
@@ -2,8 +2,6 @@
namespace Wikimedia\Purtle;
-use InvalidArgumentException;
-
/**
* Base class for RdfWriter implementations that output an N3 dialect.
*
@@ -36,21 +34,10 @@
}
protected function writeShorthand( $shorthand ) {
-// if ( $shorthand === null || $shorthand === '' ) {
-// throw new InvalidArgumentException( '$shorthand must
not be empty' );
-// }
-
$this->write( $shorthand );
}
protected function writeIRI( $iri, $trustIRI = false ) {
-// if ( $iri === null || $iri === '' ) {
-// throw new InvalidArgumentException( '$iri must not be
empty' );
-// }
-
-// if ( $iri[0] === '_' || $iri[0] === ':' || $iri[0] === '/' ||
$iri[0] === '#' ) {
-// throw new InvalidArgumentException( '$iri must be an
absolute iri: ' . $iri );
-// }
if ( !$trustIRI ) {
$iri = $this->quoter->escapeIRI( $iri );
}
@@ -58,14 +45,6 @@
}
protected function writeQName( $base, $local ) {
-// if ( $base === null ) {
-// throw new InvalidArgumentException( '$base must not be
null' );
-// }
-
-// if ( $local === null || $local === '' ) {
-// throw new InvalidArgumentException( '$local must not be
empty' );
-// }
-
$this->write( "$base:$local" );
}
--
To view, visit https://gerrit.wikimedia.org/r/208129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1295afc3af0c855ae0eac33cf73e1dd30ce83fa0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
