John Vandenberg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208503

Change subject: Python 2.6 syntax fixup
......................................................................

Python 2.6 syntax fixup

{a: b for ..} is not valid syntax in Python 2.6.
Also, this block of code is not optimal data processing.

Change-Id: I703a944df519ee175bde02a6ed67bc5b4c314005
---
M generate_user_files.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/03/208503/1

diff --git a/generate_user_files.py b/generate_user_files.py
index 57a3f60..7c99c11 100644
--- a/generate_user_files.py
+++ b/generate_user_files.py
@@ -117,10 +117,8 @@
     fam = pywikibot.family.Family.load(fam)
     if hasattr(fam, "langs"):
         if hasattr(fam, "languages_by_size"):
-            key = {lang: i for i, lang in enumerate(fam.languages_by_size)}.get
-            by_size = sorted(
-                set(fam.langs.keys()).intersection(fam.languages_by_size),
-                key=key)
+            by_size = [code for code in fam.languages_by_size
+                       if code in fam.langs.keys()]
         else:
             by_size = []
         known_langs = by_size + sorted(

-- 
To view, visit https://gerrit.wikimedia.org/r/208503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I703a944df519ee175bde02a6ed67bc5b4c314005
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to