Soeren.oldag has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208608
Change subject: Fixed some scrutinizer issues.
......................................................................
Fixed some scrutinizer issues.
Change-Id: Id28c86404dba3957b1867f62a56d8133d3ecdce4
---
M includes/CrossCheck/Comparer/StringComparer.php
M specials/SpecialExternalDbs.php
2 files changed, 2 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/08/208608/1
diff --git a/includes/CrossCheck/Comparer/StringComparer.php
b/includes/CrossCheck/Comparer/StringComparer.php
index 189550b..22bec2b 100644
--- a/includes/CrossCheck/Comparer/StringComparer.php
+++ b/includes/CrossCheck/Comparer/StringComparer.php
@@ -128,7 +128,6 @@
* @return float
*/
private function percentagePrefixSimilarity( $localValue, $externalValue )
{
- $indexForLongestPrefixMatch = null;
$prefixLength = 0; // common prefix length
$localLength = strlen( $localValue );
$externalLength = strlen( $externalValue );
@@ -152,8 +151,7 @@
* @return float
*/
private function percentagePostfixSimilarity( $localValue, $externalValue
) {
- $indexForLongestPostfixMatch = null;
- $postfixLength = 0; // common prefix length
+ $postfixLength = 0; // common postfix length
$localLength = strlen( $localValue );
$externalLength = strlen( $externalValue );
while ( $postfixLength < $localLength ) {
diff --git a/specials/SpecialExternalDbs.php b/specials/SpecialExternalDbs.php
index 1547202..36ab57a 100755
--- a/specials/SpecialExternalDbs.php
+++ b/specials/SpecialExternalDbs.php
@@ -130,8 +130,6 @@
* @return string
*/
private function formatDateTime( DateTime $dateTime ) {
- global $wgLocaltimezone;
-
$timeCorrection = $this->getUser()->getOption( 'timecorrection'
);
if ( $timeCorrection ) {
$splitTimeCorrection = explode( '|', $timeCorrection );
@@ -149,7 +147,7 @@
break;
}
} else {
- $dateTime->setTimezone( new DateTimeZone(
$wgLocaltimezone ) );
+ $dateTime->setTimezone( new DateTimeZone(
$GLOBALS['wgLocaltimezone'] ) );
}
$dateFormatPreference = $this->getUser()->getDatePreference();
--
To view, visit https://gerrit.wikimedia.org/r/208608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id28c86404dba3957b1867f62a56d8133d3ecdce4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: v1
Gerrit-Owner: Soeren.oldag <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
