jenkins-bot has submitted this change and it was merged.
Change subject: Have EntityRevision use EntityDocument
......................................................................
Have EntityRevision use EntityDocument
Change-Id: I6593180f5007970c06ea7b1df619e0dd0b08edaa
---
M lib/includes/store/EntityRevision.php
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/store/EntityRevision.php
b/lib/includes/store/EntityRevision.php
index abc2d0d..c49a791 100644
--- a/lib/includes/store/EntityRevision.php
+++ b/lib/includes/store/EntityRevision.php
@@ -3,7 +3,7 @@
namespace Wikibase;
use InvalidArgumentException;
-use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
/**
* Represents a revision of a Wikibase entity.
@@ -16,7 +16,7 @@
class EntityRevision {
/**
- * @var Entity
+ * @var EntityDocument
*/
private $entity;
@@ -31,13 +31,13 @@
private $mwTimestamp;
/**
- * @param Entity $entity
+ * @param EntityDocument $entity
* @param int $revisionId Revision ID or 0 for none
* @param string $mwTimestamp in MediaWiki format or an empty string
for none
*
* @throws InvalidArgumentException
*/
- public function __construct( Entity $entity, $revisionId = 0,
$mwTimestamp = '' ) {
+ public function __construct( EntityDocument $entity, $revisionId = 0,
$mwTimestamp = '' ) {
if ( !is_int( $revisionId ) || $revisionId < 0 ) {
throw new InvalidArgumentException( 'Revision ID must
be a non-negative integer.' );
}
@@ -52,9 +52,7 @@
}
/**
- * TODO: change return type to EntityDocument
- *
- * @return Entity
+ * @return EntityDocument
*/
public function getEntity() {
return $this->entity;
--
To view, visit https://gerrit.wikimedia.org/r/208120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6593180f5007970c06ea7b1df619e0dd0b08edaa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
