jenkins-bot has submitted this change and it was merged.
Change subject: Show loading screen while the collection editor loads
......................................................................
Show loading screen while the collection editor loads
Bug: T98025
Change-Id: Ie3ed3afcb9ef0af7b4611cd4a938da42206023ba
---
M resources/ext.gather.routes/routes.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gather.routes/routes.js
b/resources/ext.gather.routes/routes.js
index 65e4d66..9ac42ea 100644
--- a/resources/ext.gather.routes/routes.js
+++ b/resources/ext.gather.routes/routes.js
@@ -2,7 +2,8 @@
var CollectionsApi = M.require( 'ext.gather.api/CollectionsApi' ),
toast = M.require( 'toast' ),
- overlayManager = M.require( 'overlayManager' );
+ overlayManager = M.require( 'overlayManager' ),
+ loader = M.require( 'loader' );
overlayManager.add( /^\/collection\/(.*)\/(.*)$/, function ( action, id
) {
var d = $.Deferred(),
@@ -11,8 +12,9 @@
api.getCollection( id ).done( function ( collection ) {
if ( collection ) {
if ( action === 'edit' ) {
- mw.loader.using(
'ext.gather.collection.editor' ).done( function () {
+ loader.loadModule(
'ext.gather.collection.editor', true ).done( function ( loadingOverlay ) {
var CollectionEditOverlay =
M.require( 'ext.gather.collection.edit/CollectionEditOverlay' );
+ loadingOverlay.hide();
d.resolve(
new
CollectionEditOverlay( {
collection:
collection
--
To view, visit https://gerrit.wikimedia.org/r/209203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ed3afcb9ef0af7b4611cd4a938da42206023ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
