Henning Snater has submitted this change and it was merged. Change subject: StringParserTest does no longer overwrite NullParserTest ......................................................................
StringParserTest does no longer overwrite NullParserTest The test prototype defined in StringParser.tests.js, "StringParserTest", was named "NullParserTest" so it overwrote the actual "NullParserTest" defined in NullParser.tests.js. Also removed some comments in the bool parser tests which are not required anymore. Change-Id: I60f936cf02ef0873cb03e7f178ed0d23e3b189f8 --- M ValueParsers/tests/qunit/parsers/BoolParser.tests.js M ValueParsers/tests/qunit/parsers/StringParser.tests.js 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34904 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60f936cf02ef0873cb03e7f178ed0d23e3b189f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
