Mhurd has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209410
Change subject: Fix for table lead image height regression.
......................................................................
Fix for table lead image height regression.
See before/after screenshots at bottom of T97806
Change-Id: I8bdec3802cbced72adb5189179eeef31a868beff
---
M Wikipedia/assets/styleoverrides.css
M www/less/styleoverrides.less
2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/10/209410/1
diff --git a/Wikipedia/assets/styleoverrides.css
b/Wikipedia/assets/styleoverrides.css
index facb053..c9c1610 100644
--- a/Wikipedia/assets/styleoverrides.css
+++ b/Wikipedia/assets/styleoverrides.css
@@ -1 +1 @@
-a:hover{text-decoration:none
!important}.content{margin-top:0px}.lead_image_div{margin-left:-16px
!important;margin-right:-16px
!important;transition-timing-function:ease-in-out}div#lead_image_none
div.lead_image_div{height:auto
!important}#lead_image_text_container{padding:16px;pointer-events:none
!important}div#lead_image_none div#lead_image_text_container{position:relative
!important;padding-bottom:0px !important;padding-top:0px
!important}#lead_image_title,#lead_image_description{font-family:Times New
Roman;pointer-events:none
!important}#lead_image_title{padding-top:4px;line-height:100%;margin-top:6px;margin-bottom:6px}div#lead_image_none
div#lead_image_title{color:#000 !important;text-shadow:none
!important}#lead_image_description{line-height:117%}div#lead_image_none
div#lead_image_description{color:#000 !important;text-shadow:none
!important}@media
(orientation:portrait){.lead_image_div{height:12.6em;background-repeat:no-repeat;background-size:cover;color:#fff;position:relative}#lead_image_text_container{position:absolute;bottom:0px}#lead_image_title,#lead_image_description{text-shadow:0
1px .5px rgba(0,0,0,0.25)}}@media
(orientation:landscape){.lead_image_div{background-size:0
0;height:auto;color:#000;padding-bottom:0px;padding-top:0px}#lead_image_text_container{padding-bottom:0px;padding-top:0px}}.content_block,.image_overflow_x_container{clear:both;overflow-x:auto}#edit_section_button_0{margin-top:6px}#section_heading_and_content_block_0{margin-top:13px}.ios-disambiguation-item-anchor{display:block;padding-top:8px;padding-bottom:8px}.ios-issue-item{padding-top:8px;padding-bottom:8px}.ios-issue-item
*{font-weight:normal
!important}#disambig_sub_container,#issues_sub_container{background-color:#fff
!important;border-bottom:1px solid
#ccc;padding-top:6px;padding-bottom:12px;margin-bottom:12px}#issues_container_close_button{color:#333;display:none;font-weight:bold;padding:4px
20px 4px 20px}a.issues_button,a.disambig_button{padding:4px 0px 4px 0px
!important}span.issues_separator{padding-top:4px!important;padding-bottom:4px!important}div.issues_container{margin-bottom:1.8em
!important}*{box-sizing:border-box}
\ No newline at end of file
+a:hover{text-decoration:none
!important}.content{margin-top:0px}.lead_image_div{margin-left:-16px
!important;margin-right:-16px
!important;transition-timing-function:ease-in-out}div#lead_image_none
div.lead_image_div{height:auto
!important}#lead_image_text_container{padding:16px;pointer-events:none
!important}div#lead_image_none div#lead_image_text_container{position:relative
!important;padding-bottom:0px !important;padding-top:0px
!important}#lead_image_title,#lead_image_description{font-family:Times New
Roman;pointer-events:none
!important}#lead_image_title{padding-top:4px;line-height:100%;margin-top:6px;margin-bottom:6px}div#lead_image_none
div#lead_image_title{color:#000 !important;text-shadow:none
!important}#lead_image_description{line-height:117%}div#lead_image_none
div#lead_image_description{color:#000 !important;text-shadow:none
!important}@media
(orientation:portrait){.lead_image_div{height:150pt;background-repeat:no-repeat;background-size:cover;color:#fff;position:relative}#lead_image_text_container{position:absolute;bottom:0px}#lead_image_title,#lead_image_description{text-shadow:0
1px .5px rgba(0,0,0,0.25)}}@media (orientation:portrait) and
(min-device-width:768px){.lead_image_div{height:250pt}}@media
(orientation:landscape){.lead_image_div{background-size:0
0;height:auto;color:#000;padding-bottom:0px;padding-top:0px}#lead_image_text_container{padding-bottom:0px;padding-top:0px}}.content_block,.image_overflow_x_container{clear:both;overflow-x:auto}#edit_section_button_0{margin-top:6px}#section_heading_and_content_block_0{margin-top:13px}.ios-disambiguation-item-anchor{display:block;padding-top:8px;padding-bottom:8px}.ios-issue-item{padding-top:8px;padding-bottom:8px}.ios-issue-item
*{font-weight:normal
!important}#disambig_sub_container,#issues_sub_container{background-color:#fff
!important;border-bottom:1px solid
#ccc;padding-top:6px;padding-bottom:12px;margin-bottom:12px}#issues_container_close_button{color:#333;display:none;font-weight:bold;padding:4px
20px 4px 20px}a.issues_button,a.disambig_button{padding:4px 0px 4px 0px
!important}span.issues_separator{padding-top:4px!important;padding-bottom:4px!important}div.issues_container{margin-bottom:1.8em
!important}*{box-sizing:border-box}
\ No newline at end of file
diff --git a/www/less/styleoverrides.less b/www/less/styleoverrides.less
index 30ef4a3..c11cc53 100644
--- a/www/less/styleoverrides.less
+++ b/www/less/styleoverrides.less
@@ -73,13 +73,20 @@
@media (orientation: portrait) {
.lead_image_div {
- height:12.6em;
+ height:150pt;
background-repeat: no-repeat;
background-size:cover;
color:#fff;
position: relative;
}
+ /* Tablet override */
+ @media (min-device-width: 768px) {
+ .lead_image_div {
+ height:250pt;
+ }
+ }
+
#lead_image_text_container {
position: absolute;
bottom: 0px;
--
To view, visit https://gerrit.wikimedia.org/r/209410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bdec3802cbced72adb5189179eeef31a868beff
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
