Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209421
Change subject: Remove error suppression for Handlebars compilation
......................................................................
Remove error suppression for Handlebars compilation
Templates are only compiled in development mode, so there is no reason
to hide errors (and @ is not allowed by our coding conventions). Also,
it will throw an exception afterwards anyway,unless there has been no
change.
Change-Id: I1172992e87713560638e29473d32f8f8be7c0a9a
---
M includes/TemplateHelper.php
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/21/209421/1
diff --git a/includes/TemplateHelper.php b/includes/TemplateHelper.php
index 1501ea9..17f9b78 100644
--- a/includes/TemplateHelper.php
+++ b/includes/TemplateHelper.php
@@ -97,8 +97,7 @@
if ( !$code ) {
throw new FlowException( "Failed to compile
template '$templateName'." );
}
- // @FIXME: Using @ is bad.
- $success = @file_put_contents( $filenames['compiled'],
$code );
+ $success = file_put_contents( $filenames['compiled'],
$code );
// failed to recompile template (OS permissions?);
unless the
// content hasn't changes, throw an exception!
@@ -803,4 +802,3 @@
);
}
}
-
--
To view, visit https://gerrit.wikimedia.org/r/209421
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1172992e87713560638e29473d32f8f8be7c0a9a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
