Bgerstle has submitted this change and it was merged. Change subject: Remove superfluous appInstallID from URLs ......................................................................
Remove superfluous appInstallID from URLs Change-Id: Ic20a8f2ad65af2cfeafc7fcc7be41087afc45edd --- M Wikipedia/Networking/Fetchers/ArticleFetcher.m 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Nuria: Looks good to me, but someone else must approve Bgerstle: Looks good to me, approved jenkins-bot: Verified Objections: Dr0ptp4kt: There's a problem with this change, please improve Deskana: There's a problem with this change, please improve diff --git a/Wikipedia/Networking/Fetchers/ArticleFetcher.m b/Wikipedia/Networking/Fetchers/ArticleFetcher.m index f06c38d..8c403e3 100644 --- a/Wikipedia/Networking/Fetchers/ArticleFetcher.m +++ b/Wikipedia/Networking/Fetchers/ArticleFetcher.m @@ -161,12 +161,6 @@ @"image"]) }.mutableCopy; - if ([SessionSingleton sharedInstance].shouldSendUsageReports) { - // !!!: (bgerstle Feb 4 2015) we're getting an "unrecognized parameter" warning for appInstallID - ReadingActionFunnel* funnel = [[ReadingActionFunnel alloc] init]; - params[@"appInstallID"] = funnel.appInstallID; - } - return params; } -- To view, visit https://gerrit.wikimedia.org/r/205980 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20a8f2ad65af2cfeafc7fcc7be41087afc45edd Gerrit-PatchSet: 3 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org> Gerrit-Reviewer: Bgerstle <bgers...@wikimedia.org> Gerrit-Reviewer: Deskana <dga...@wikimedia.org> Gerrit-Reviewer: Dr0ptp4kt <ab...@wikimedia.org> Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org> Gerrit-Reviewer: Joal <j...@wikimedia.org> Gerrit-Reviewer: Madhuvishy <mviswanat...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: Nuria <nu...@wikimedia.org> Gerrit-Reviewer: OliverKeyes <oke...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits