jenkins-bot has submitted this change and it was merged.
Change subject: Use new TabSelectWidget in link inspector
......................................................................
Use new TabSelectWidget in link inspector
Don't use the full IndexLayout for now as it doesn't
work easily in variable height situations.
Depends on this feature being preset in MW core.
Bug: T97878
Change-Id: I5d949bf69b0721b288c37c1f12210b0265658eb5
---
M modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js
M modules/ve-mw/ui/styles/inspectors/ve.ui.MWLinkAnnotationInspector.css
2 files changed, 5 insertions(+), 16 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js
b/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js
index 3172d40..1a86b06 100644
--- a/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js
+++ b/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js
@@ -48,11 +48,11 @@
} );
this.externalAnnotationInput = new
ve.ui.MWExternalLinkAnnotationWidget();
- this.linkTypeSelect = new OO.ui.ButtonSelectWidget( {
+ this.linkTypeSelect = new OO.ui.TabSelectWidget( {
classes: [ 've-ui-mwLinkAnnotationInspector-linkTypeSelect' ],
items: [
- new OO.ui.ButtonOptionWidget( { framed: false, data:
'internal', label: ve.msg( 'visualeditor-linkinspector-button-link-internal' )
} ),
- new OO.ui.ButtonOptionWidget( { framed: false, data:
'external', label: ve.msg( 'visualeditor-linkinspector-button-link-external' )
} )
+ new OO.ui.TabOptionWidget( { data: 'internal', label:
ve.msg( 'visualeditor-linkinspector-button-link-internal' ) } ),
+ new OO.ui.TabOptionWidget( { data: 'external', label:
ve.msg( 'visualeditor-linkinspector-button-link-external' ) } )
]
} );
diff --git
a/modules/ve-mw/ui/styles/inspectors/ve.ui.MWLinkAnnotationInspector.css
b/modules/ve-mw/ui/styles/inspectors/ve.ui.MWLinkAnnotationInspector.css
index 08f7d9e..85c2b18 100644
--- a/modules/ve-mw/ui/styles/inspectors/ve.ui.MWLinkAnnotationInspector.css
+++ b/modules/ve-mw/ui/styles/inspectors/ve.ui.MWLinkAnnotationInspector.css
@@ -5,17 +5,6 @@
* @license The MIT License (MIT); see LICENSE.txt
*/
-.ve-ui-mwLinkAnnotationInspector-linkTypeSelect .oo-ui-buttonOptionWidget
.oo-ui-buttonElement-button {
- height: auto;
- margin: 0;
- padding: 0 0.5em;
- color: #888;
-}
-
-.ve-ui-mwLinkAnnotationInspector-linkTypeSelect .oo-ui-optionWidget-selected
.oo-ui-buttonElement-button {
- background: #eee;
-}
-
-.ve-ui-mwLinkAnnotationInspector .oo-ui-iconElement-icon {
- opacity: 0.4;
+.ve-ui-mwLinkAnnotationInspector-linkTypeSelect {
+ margin: -0.75em -0.75em 0.75em -0.75em;
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/208619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d949bf69b0721b288c37c1f12210b0265658eb5
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
