Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209695
Change subject: Only apply annotations if 'done' is clicked
......................................................................
Only apply annotations if 'done' is clicked
Change-Id: Id4f363320121d0152e934c411ed34e514cff5455
---
M src/ui/inspectors/ve.ui.AnnotationInspector.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/95/209695/1
diff --git a/src/ui/inspectors/ve.ui.AnnotationInspector.js
b/src/ui/inspectors/ve.ui.AnnotationInspector.js
index 0802c28..0f2b6a6 100644
--- a/src/ui/inspectors/ve.ui.AnnotationInspector.js
+++ b/src/ui/inspectors/ve.ui.AnnotationInspector.js
@@ -289,11 +289,11 @@
}
if ( !remove ) {
+ if ( data.action !== 'done' ) {
+ surfaceModel.popStaging();
+ return;
+ }
if ( this.initialSelection.isCollapsed() ) {
- if ( data.action !== 'done' ) {
- surfaceModel.popStaging();
- return;
- }
insertText = true;
}
if ( annotation ) {
--
To view, visit https://gerrit.wikimedia.org/r/209695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4f363320121d0152e934c411ed34e514cff5455
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
