Jcrespo has submitted this change and it was merged. Change subject: --no-version-check to be used by default on pt-online-schema-change ......................................................................
--no-version-check to be used by default on pt-online-schema-change The "version check" feature was introduced on 2012 on percona-toolkit and percona-xtrabackup: https://www.percona.com/blog/2012/09/10/introducing-the-version-check-feature-in-percona-toolkit/ and enabled by default in 2014. Since then, the communication to v.percona.com has been in the past show to be a potential (although not critical) security issue: https://security-tracker.debian.org/tracker/CVE-2015-1027 so it should be disabled by default for production servers. Change-Id: I96a43fd963edb3074a9c17da31d1f2acda00aa78 --- M dbtools/osc_host.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jcrespo: Verified; Looks good to me, approved Springle: Looks good to me, but someone else must approve diff --git a/dbtools/osc_host.sh b/dbtools/osc_host.sh index 57a1373..1894683 100755 --- a/dbtools/osc_host.sh +++ b/dbtools/osc_host.sh @@ -205,6 +205,7 @@ --dry-run \ --alter-foreign-keys-method=none --force \ --nocheck-replication-filters \ + --no-version-check \ $ptdryargs \ --alter "$altersql" \ D=$db,t=$table,h=$host,P=$port,u=$user >/dev/null @@ -217,6 +218,7 @@ --execute \ --alter-foreign-keys-method=none --force \ --nocheck-replication-filters \ + --no-version-check \ $ptargs \ --alter "$altersql" \ D=$db,t=$table,h=$host,P=$port,u=$user -- To view, visit https://gerrit.wikimedia.org/r/210863 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96a43fd963edb3074a9c17da31d1f2acda00aa78 Gerrit-PatchSet: 3 Gerrit-Project: operations/software Gerrit-Branch: master Gerrit-Owner: Jcrespo <jcre...@wikimedia.org> Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org> Gerrit-Reviewer: Springle <sprin...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
