jenkins-bot has submitted this change and it was merged. Change subject: Timestamp from Year/Month selector on forms should be wiki time ......................................................................
Timestamp from Year/Month selector on forms should be wiki time When searching for a year/month with the year/month selector on Special:Contributions or action=history the given time should be treated as wiki time and therefore needs adjust to UTC before search in the Database. This has no effect on wikis with UTC like enwiki, but for example on dewiki with an offset from 1hour/2hour. Change-Id: Iccd41d19a360827b9c80b66582ca0daa7ed7576c --- M includes/pager/ReverseChronologicalPager.php 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/pager/ReverseChronologicalPager.php b/includes/pager/ReverseChronologicalPager.php index 4f8c438..ee6e26c 100644 --- a/includes/pager/ReverseChronologicalPager.php +++ b/includes/pager/ReverseChronologicalPager.php @@ -113,6 +113,10 @@ $ymd = 20320101; } - $this->mOffset = $this->mDb->timestamp( "${ymd}000000" ); + // Treat the given time in the wiki timezone and get a UTC timestamp for the database lookup + $timestamp = MWTimestamp::getInstance( "${ymd}000000" ); + $timestamp->setTimeZone( $this->getConfig()->get( 'Localtimezone' ) ); + + $this->mOffset = $this->mDb->timestamp( $timestamp->getTimestamp() ); } } -- To view, visit https://gerrit.wikimedia.org/r/205017 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccd41d19a360827b9c80b66582ca0daa7ed7576c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits