jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
......................................................................


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I92eee336132de57b9759ba67fed1f060bd6a881e
---
M Echo.php
M special/SpecialNotifications.php
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Echo.php b/Echo.php
index e1c461c..276e090 100644
--- a/Echo.php
+++ b/Echo.php
@@ -64,7 +64,6 @@
 
 // Special page
 $wgSpecialPages['Notifications'] = 'SpecialNotifications';
-$wgSpecialPageGroups['Notifications'] = 'users';
 
 // Housekeeping hooks
 $wgHooks['LoadExtensionSchemaUpdates'][] = 'EchoHooks::getSchemaUpdates';
diff --git a/special/SpecialNotifications.php b/special/SpecialNotifications.php
index c8a0d08..d34d0b7 100644
--- a/special/SpecialNotifications.php
+++ b/special/SpecialNotifications.php
@@ -177,4 +177,8 @@
                );
                return $lang->pipeList( $subtitleLinks );
        }
+
+       protected function getGroupName() {
+               return 'users';
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92eee336132de57b9759ba67fed1f060bd6a881e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to