Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/211414
Change subject: Replace deprecated $wgSpecialPageGroups ...................................................................... Replace deprecated $wgSpecialPageGroups $wgSpecialPageGroups is deprecated since 1.21 override SpecialPage::getGroupName instead Min version on mw.org is 1.21 Change-Id: Ida8b15d55badead625f8b54fae1429a93512f10d --- M OmegaWiki/SpecialAddCollection.php M OmegaWiki/SpecialConceptMapping.php M OmegaWiki/SpecialImportLangNames.php M OmegaWiki/SpecialNeedsTranslation.php M includes/setup/OWSpecials.php M includes/specials/SpecialDatasearch.php M includes/specials/SpecialOWAddFromExternalAPI.php M includes/specials/SpecialOWDownloads.php M includes/specials/SpecialOWStatistics.php 9 files changed, 29 insertions(+), 25 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData refs/changes/14/211414/1 diff --git a/OmegaWiki/SpecialAddCollection.php b/OmegaWiki/SpecialAddCollection.php index a820583..029d204 100644 --- a/OmegaWiki/SpecialAddCollection.php +++ b/OmegaWiki/SpecialAddCollection.php @@ -62,5 +62,9 @@ '', array( 'create' => wfMessage( 'ow_create' )->text() ) ) ); } + + protected function getGroupName() { + return 'other'; + } } diff --git a/OmegaWiki/SpecialConceptMapping.php b/OmegaWiki/SpecialConceptMapping.php index 4408e87..e70203b 100644 --- a/OmegaWiki/SpecialConceptMapping.php +++ b/OmegaWiki/SpecialConceptMapping.php @@ -189,5 +189,8 @@ } } + protected function getGroupName() { + return 'other'; + } } diff --git a/OmegaWiki/SpecialImportLangNames.php b/OmegaWiki/SpecialImportLangNames.php index d0d7bdb..569d2d2 100644 --- a/OmegaWiki/SpecialImportLangNames.php +++ b/OmegaWiki/SpecialImportLangNames.php @@ -111,4 +111,8 @@ $wikipage = new WikiPage( $titleObj ); $wikipage->doEdit( $content, 'updated via Special:ImportLangNames' ); } + + protected function getGroupName() { + return 'other'; + } } diff --git a/OmegaWiki/SpecialNeedsTranslation.php b/OmegaWiki/SpecialNeedsTranslation.php index 09dea95..4c5dd76 100644 --- a/OmegaWiki/SpecialNeedsTranslation.php +++ b/OmegaWiki/SpecialNeedsTranslation.php @@ -194,6 +194,10 @@ $wgOut->addHTML( "Showing $nbshown out of $queryResultCount" ) ; $wgOut->addHTML( $editor->view( new IdStack( "expression" ), $recordSet ) ); } + + protected function getGroupName() { + return 'maintenance'; + } } diff --git a/includes/setup/OWSpecials.php b/includes/setup/OWSpecials.php index 6b12fdc..0f5c73f 100644 --- a/includes/setup/OWSpecials.php +++ b/includes/setup/OWSpecials.php @@ -131,29 +131,6 @@ // $wgSpecialPages['Transaction'] = 'SpecialTransaction'; -# Tell MediaWiki about which group the new special page belongs to -# maintenance = Maintenance reports -# wiki = Data and tools -# others = Other Special pages -/** - * == UnlistedSpecialPage == - * SpecialCopy - * SpecialSelect - * SpecialSuggest - * SpecialPopupEditor - */ - -$wgSpecialPageGroups[ 'AddCollection' ] = 'other'; -$wgSpecialPageGroups[ 'ConceptMapping' ] = 'other'; -$wgSpecialPageGroups[ 'ow_data_search' ] = 'wiki'; -$wgSpecialPageGroups[ 'ImportLangNames' ] = 'other'; -$wgSpecialPageGroups[ 'NeedsTranslation' ] = 'maintenance'; - -$wgSpecialPageGroups[ 'ow_statistics' ] = 'wiki'; -$wgSpecialPageGroups[ 'ow_downloads' ] = 'wiki'; - -// special page with conditional groups - // ow_addFromExtAPI global $wgWldProcessExternalAPIClasses, $wgWldExtenalResourceLanguages, $wgWldScriptPath; @@ -172,8 +149,6 @@ } if ( $wgWldProcessExternalAPIClasses ) { - $wgSpecialPageGroups[ 'ow_addFromExtAPI' ] = 'maintenance'; - $wgResourceModules['ext.OwAddFromExtAPI.js'] = $resourcePathArray + array( 'scripts' => 'omegawiki-addExtAPI.js' ); diff --git a/includes/specials/SpecialDatasearch.php b/includes/specials/SpecialDatasearch.php index 5bfdb79..585696b 100644 --- a/includes/specials/SpecialDatasearch.php +++ b/includes/specials/SpecialDatasearch.php @@ -518,4 +518,8 @@ return $linksHtml; } + + protected function getGroupName() { + return 'wiki'; + } } diff --git a/includes/specials/SpecialOWAddFromExternalAPI.php b/includes/specials/SpecialOWAddFromExternalAPI.php index f739063..cdc60fa 100644 --- a/includes/specials/SpecialOWAddFromExternalAPI.php +++ b/includes/specials/SpecialOWAddFromExternalAPI.php @@ -143,6 +143,9 @@ require_once( 'ExternalWordnik.php' ); } + protected function getGroupName() { + return 'maintenance'; + } } /** @brief This class handles External Resources. diff --git a/includes/specials/SpecialOWDownloads.php b/includes/specials/SpecialOWDownloads.php index b5aaecd..8ff6006 100644 --- a/includes/specials/SpecialOWDownloads.php +++ b/includes/specials/SpecialOWDownloads.php @@ -523,4 +523,7 @@ $contents = null; } + protected function getGroupName() { + return 'wiki'; + } } diff --git a/includes/specials/SpecialOWStatistics.php b/includes/specials/SpecialOWStatistics.php index bc5e6d5..f59c0f1 100644 --- a/includes/specials/SpecialOWStatistics.php +++ b/includes/specials/SpecialOWStatistics.php @@ -379,4 +379,8 @@ return $row; } + + protected function getGroupName() { + return 'wiki'; + } } -- To view, visit https://gerrit.wikimedia.org/r/211414 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida8b15d55badead625f8b54fae1429a93512f10d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiLexicalData Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits