jenkins-bot has submitted this change and it was merged.
Change subject: Replace deprecated $wgSpecialPageGroups
......................................................................
Replace deprecated $wgSpecialPageGroups
$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead
Change-Id: Ic879fc98ba2ebd960d9d061f51ff9372ec19d06c
(cherry picked from commit 91eb69f2a68ab53bbfcfafaaf3d0b7d9e056a11b)
---
M CodeReview.php
M extension.json
M ui/SpecialCode.php
M ui/SpecialRepoAdmin.php
4 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CodeReview.php b/CodeReview.php
index 142f59d..3b1aa15 100644
--- a/CodeReview.php
+++ b/CodeReview.php
@@ -112,9 +112,7 @@
/******** SPECIAL PAGE SETUP ********/
$wgSpecialPages['Code'] = 'SpecialCode';
-$wgSpecialPageGroups['Code'] = 'developer';
$wgSpecialPages['RepoAdmin'] = 'SpecialRepoAdmin';
-$wgSpecialPageGroups['RepoAdmin'] = 'developer';
/******** API SETUP ********/
diff --git a/extension.json b/extension.json
index 06d3ab2..b585cb5 100644
--- a/extension.json
+++ b/extension.json
@@ -119,10 +119,6 @@
"localBasePath": "modules",
"remoteExtPath": "CodeReview/modules"
},
- "SpecialPageGroups": {
- "Code": "developer",
- "RepoAdmin": "developer"
- },
"GroupPermissions": {
"*": {
"codereview-use": true
diff --git a/ui/SpecialCode.php b/ui/SpecialCode.php
index d6a7aa3..a917226 100644
--- a/ui/SpecialCode.php
+++ b/ui/SpecialCode.php
@@ -139,4 +139,8 @@
}
return $view;
}
+
+ protected function getGroupName() {
+ return 'developer';
+ }
}
diff --git a/ui/SpecialRepoAdmin.php b/ui/SpecialRepoAdmin.php
index b00de90..03e15d9 100644
--- a/ui/SpecialRepoAdmin.php
+++ b/ui/SpecialRepoAdmin.php
@@ -29,6 +29,10 @@
}
$view->execute();
}
+
+ protected function getGroupName() {
+ return 'developer';
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/211443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic879fc98ba2ebd960d9d061f51ff9372ec19d06c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: REL1_25
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
