jenkins-bot has submitted this change and it was merged.
Change subject: Replace deprecated $wgSpecialPageGroups
......................................................................
Replace deprecated $wgSpecialPageGroups
$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead
For backport of Idccbe41b649de93548c5b0fca03145da716bcc65
Change-Id: I9b8e6aad922d45b9bb3a0665fcd3ddce6f82f04e
(cherry picked from commit 32bb10553b035d731789ff0a0f4bc122e6632e90)
---
M CheckUser.php
M extension.json
M specials/SpecialCheckUser.php
M specials/SpecialCheckUserLog.php
4 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CheckUser.php b/CheckUser.php
index 5fbc47b..0b7c09e 100644
--- a/CheckUser.php
+++ b/CheckUser.php
@@ -99,9 +99,7 @@
// Set up the new special page
$wgSpecialPages['CheckUser'] = 'CheckUser';
-$wgSpecialPageGroups['CheckUser'] = 'users';
$wgSpecialPages['CheckUserLog'] = 'SpecialCheckUserLog';
-$wgSpecialPageGroups['CheckUserLog'] = 'changes';
$wgAutoloadClasses['CheckUser'] = $dir . 'specials/SpecialCheckUser.php';
$wgAutoloadClasses['CheckUserHooks'] = $dir . 'CheckUser.hooks.php';
diff --git a/extension.json b/extension.json
index 9e62d31..67b8c67 100644
--- a/extension.json
+++ b/extension.json
@@ -79,10 +79,6 @@
"localBasePath": "",
"remoteExtPath": "CheckUser"
},
- "SpecialPageGroups": {
- "CheckUser": "users",
- "CheckUserLog": "changes"
- },
"GroupPermissions": {
"checkuser": {
"checkuser": true,
diff --git a/specials/SpecialCheckUser.php b/specials/SpecialCheckUser.php
index eaa3eb5..5f8af03 100644
--- a/specials/SpecialCheckUser.php
+++ b/specials/SpecialCheckUser.php
@@ -1438,5 +1438,9 @@
), __METHOD__ );
return true;
}
+
+ protected function getGroupName() {
+ return 'users';
+ }
}
diff --git a/specials/SpecialCheckUserLog.php b/specials/SpecialCheckUserLog.php
index 7470de0..190f612 100644
--- a/specials/SpecialCheckUserLog.php
+++ b/specials/SpecialCheckUserLog.php
@@ -122,4 +122,8 @@
$pager->getNavigationBar()
);
}
+
+ protected function getGroupName() {
+ return 'changes';
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/211442
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b8e6aad922d45b9bb3a0665fcd3ddce6f82f04e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CheckUser
Gerrit-Branch: REL1_25
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
