jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
......................................................................


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Min version on mw.org is 1.22

Change-Id: I9d97b5b85707bb920ff786c00abac5ac409fe70e
---
M BibManager.php
M includes/specials/SpecialBibManagerCreate.php
M includes/specials/SpecialBibManagerDelete.php
M includes/specials/SpecialBibManagerEdit.php
M includes/specials/SpecialBibManagerExport.php
M includes/specials/SpecialBibManagerImport.php
M includes/specials/SpecialBibManagerList.php
M includes/specials/SpecialBibManagerListAuthors.php
8 files changed, 27 insertions(+), 10 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/BibManager.php b/BibManager.php
index 1dd8a69..b351dc7 100644
--- a/BibManager.php
+++ b/BibManager.php
@@ -72,15 +72,6 @@
 $wgSpecialPages['BibManagerCreate']      = 'SpecialBibManagerCreate';
 $wgSpecialPages['BibManagerEdit']        = 'SpecialBibManagerEdit';
 
-//Add SpecialPages to group
-$wgSpecialPageGroups['BibManagerList']        = 'bibmanager';
-$wgSpecialPageGroups['BibManagerListAuthors'] = 'bibmanager';
-$wgSpecialPageGroups['BibManagerImport']      = 'bibmanager';
-$wgSpecialPageGroups['BibManagerExport']      = 'bibmanager';
-$wgSpecialPageGroups['BibManagerDelete']      = 'bibmanager';
-$wgSpecialPageGroups['BibManagerCreate']      = 'bibmanager';
-$wgSpecialPageGroups['BibManagerEdit']        = 'bibmanager';
-
 //Add Hookhandler
 $wgHooks['ParserFirstCallInit'][] = 'BibManagerHooks::onParserFirstCallInit';
 $wgHooks['BeforePageDisplay'][]   = 'BibManagerHooks::onBeforePageDisplay';
@@ -139,4 +130,4 @@
 
 $wgAvailableRights[] = 'bibmanageredit';
 $wgAvailableRights[] = 'bibmanagerdelete';
-$wgAvailableRights[] = 'bibmanagercreate';
\ No newline at end of file
+$wgAvailableRights[] = 'bibmanagercreate';
diff --git a/includes/specials/SpecialBibManagerCreate.php 
b/includes/specials/SpecialBibManagerCreate.php
index 1f11922..f6e5742 100644
--- a/includes/specials/SpecialBibManagerCreate.php
+++ b/includes/specials/SpecialBibManagerCreate.php
@@ -92,4 +92,8 @@
                );
                return true;
        }
+
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
diff --git a/includes/specials/SpecialBibManagerDelete.php 
b/includes/specials/SpecialBibManagerDelete.php
index b6e6107..5d269d3 100644
--- a/includes/specials/SpecialBibManagerDelete.php
+++ b/includes/specials/SpecialBibManagerDelete.php
@@ -101,4 +101,8 @@
                }
                return $result;
        }
+
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
diff --git a/includes/specials/SpecialBibManagerEdit.php 
b/includes/specials/SpecialBibManagerEdit.php
index eef6cd8..85f69d8 100644
--- a/includes/specials/SpecialBibManagerEdit.php
+++ b/includes/specials/SpecialBibManagerEdit.php
@@ -145,4 +145,8 @@
 
                return true;
        }
+
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
diff --git a/includes/specials/SpecialBibManagerExport.php 
b/includes/specials/SpecialBibManagerExport.php
index f6434d6..b0ce846 100644
--- a/includes/specials/SpecialBibManagerExport.php
+++ b/includes/specials/SpecialBibManagerExport.php
@@ -55,4 +55,7 @@
                echo $out;
        }
 
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
\ No newline at end of file
diff --git a/includes/specials/SpecialBibManagerImport.php 
b/includes/specials/SpecialBibManagerImport.php
index ebdf1e3..34eea37 100644
--- a/includes/specials/SpecialBibManagerImport.php
+++ b/includes/specials/SpecialBibManagerImport.php
@@ -100,4 +100,8 @@
 
                return true;
        }
+
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
diff --git a/includes/specials/SpecialBibManagerList.php 
b/includes/specials/SpecialBibManagerList.php
index 03c98fa..bc6125b 100644
--- a/includes/specials/SpecialBibManagerList.php
+++ b/includes/specials/SpecialBibManagerList.php
@@ -92,4 +92,8 @@
        public function submitForm ( $formData ) {
                return false;
        }
+
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
diff --git a/includes/specials/SpecialBibManagerListAuthors.php 
b/includes/specials/SpecialBibManagerListAuthors.php
index b5a317e..de037bc 100644
--- a/includes/specials/SpecialBibManagerListAuthors.php
+++ b/includes/specials/SpecialBibManagerListAuthors.php
@@ -42,4 +42,7 @@
                return false;
        }
 
+       protected function getGroupName() {
+               return 'bibmanager';
+       }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/211415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d97b5b85707bb920ff786c00abac5ac409fe70e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BibManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to