Ori.livneh has submitted this change and it was merged.

Change subject: Encode the tag name to be path-safe - fixes T98411
......................................................................


Encode the tag name to be path-safe - fixes T98411

Bug: T98411
Change-Id: I03eebe89a31748cdc41cd60ea29d9baf6036accd
---
M modules/phabricator/manifests/init.pp
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/phabricator/manifests/init.pp 
b/modules/phabricator/manifests/init.pp
index ecc1e5b..ac4ac94 100644
--- a/modules/phabricator/manifests/init.pp
+++ b/modules/phabricator/manifests/init.pp
@@ -213,9 +213,8 @@
     }
 
     if ($extension_tag) {
-
-        $ext_lock_path = "${phabdir}/extension_lock_${extension_tag}"
-
+        $ext_lock_name = regsubst($extension_tag, '\W', '-', 'G')
+        $ext_lock_path = "${phabdir}/extension_lock_${ext_lock_name}"
         git::install { 'phabricator/extensions':
             directory => "${phabdir}/extensions",
             git_tag   => $extension_tag,

-- 
To view, visit https://gerrit.wikimedia.org/r/212246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03eebe89a31748cdc41cd60ea29d9baf6036accd
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: 20after4 <mmod...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to