Alexandros Kosiaris has submitted this change and it was merged.

Change subject: puppetmaster: cleanups in gitsync
......................................................................


puppetmaster: cleanups in gitsync

Specify owner, group for file resources
Remove redundant dependency

Change-Id: I567a60c8355209e6a464529a5d3879011c3a9c01
---
M modules/puppetmaster/manifests/gitsync.pp
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/puppetmaster/manifests/gitsync.pp 
b/modules/puppetmaster/manifests/gitsync.pp
index b46e2fe..fff429f 100644
--- a/modules/puppetmaster/manifests/gitsync.pp
+++ b/modules/puppetmaster/manifests/gitsync.pp
@@ -16,6 +16,8 @@
     file { '/usr/local/bin/git-sync-upstream':
         ensure  => present,
         content => template('puppetmaster/git-sync-upstream.erb'),
+        owner   => 'root',
+        group   => 'root',
         mode    => '0555',
     }
 
@@ -30,7 +32,8 @@
     file { '/etc/logrotate.d/git-sync-upstream':
         ensure  => present,
         source  => 
'puppet:///modules/puppetmaster/git-sync-upstream.logrotate',
+        owner   => 'root',
+        group   => 'root',
         mode    => '0444',
-        require => Cron['rebase_operations_puppet'],
     }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/209263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I567a60c8355209e6a464529a5d3879011c3a9c01
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to