jenkins-bot has submitted this change and it was merged.
Change subject: [roundtrip-test] Replace hardcoded regexp with a DOMUtils
helper.
......................................................................
[roundtrip-test] Replace hardcoded regexp with a DOMUtils helper.
Change-Id: I1e6dd65fba2a72b29bd38da17e556786e3d027c0
---
M tests/roundtrip-test.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Arlolra: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/roundtrip-test.js b/tests/roundtrip-test.js
index 0a06953..41a6de9 100755
--- a/tests/roundtrip-test.js
+++ b/tests/roundtrip-test.js
@@ -197,12 +197,12 @@
}
// Cannot inspect template content subtree at a finer grained level
- var typeOf = node.getAttribute('typeof') || '';
- if (/\bmw:(?:Transclusion\b|Param\b|Extension\/[^\s]+)/.test(typeOf)) {
+ if (DU.isFirstEncapsulationWrapperNode(node)) {
return [node];
}
// Cannot inspect image subtree at a finer grained level
+ var typeOf = node.getAttribute('typeof') || '';
if (/\bmw:Image(\/|$)/.test(typeOf) &&
/^(FIGURE|SPAN)$/.test(node.nodeName)) {
return [node];
}
--
To view, visit https://gerrit.wikimedia.org/r/212301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e6dd65fba2a72b29bd38da17e556786e3d027c0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
