Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212835
Change subject: Fix tabbing
......................................................................
Fix tabbing
Remove tabindex on input fields, add autofocus to first one.
Test Plan: With this, tabbing through the fields of Special:Interwiki/add on my
labs
instance does the right thing.
Bug: T100052
Change-Id: I3fa0c1ea3d805ce0ad423d503ef3f012eb0e4bca
---
M Interwiki_body.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Interwiki
refs/changes/35/212835/1
diff --git a/Interwiki_body.php b/Interwiki_body.php
index bd1fe79..47504cd 100755
--- a/Interwiki_body.php
+++ b/Interwiki_body.php
@@ -135,7 +135,7 @@
} elseif ( $action === 'add' ) {
$prefix = $request->getVal( 'wpInterwikiPrefix',
$request->getVal( 'prefix' ) );
$prefixElement = Xml::input( 'wpInterwikiPrefix', 20,
$prefix,
- array( 'tabindex' => 1, 'id' =>
'mw-interwiki-prefix', 'maxlength' => 20 ) );
+ array( 'autofocus' => true, 'id' =>
'mw-interwiki-prefix', 'maxlength' => 20 ) );
$local = $request->getCheck( 'wpInterwikiLocal' );
$trans = $request->getCheck( 'wpInterwikiTrans' );
$defaulturl = $request->getVal( 'wpInterwikiURL',
$this->msg( 'interwiki-defaulturl' )->text() );
@@ -177,7 +177,7 @@
Xml::label( $this->msg(
'interwiki-url-label' )->text(), 'mw-interwiki-url' )
) .
Html::rawElement( 'td', $input, Xml::input(
'wpInterwikiURL', 60, $defaulturl,
- array( 'tabindex' => 1, 'maxlength' =>
200, 'id' => 'mw-interwiki-url' ) ) )
+ array( 'maxlength' => 200, 'id' =>
'mw-interwiki-url' ) ) )
);
}
@@ -197,7 +197,7 @@
Html::rawElement( 'td', $label,
Xml::label( $this->msg( 'interwiki_reasonfield' )->text(),
"mw-interwiki-{$action}reason"
) ) .
Html::rawElement( 'td', $input,
Xml::input( 'wpInterwikiReason', 60, '',
- array( 'tabindex' => 1, 'id' =>
"mw-interwiki-{$action}reason", 'maxlength' => 200 ) ) )
+ array( 'id' =>
"mw-interwiki-{$action}reason", 'maxlength' => 200 ) ) )
) . Html::rawElement( 'tr', null,
Html::rawElement( 'td', null, '' ) .
Html::rawElement( 'td', array( 'class'
=> 'mw-submit' ),
--
To view, visit https://gerrit.wikimedia.org/r/212835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fa0c1ea3d805ce0ad423d503ef3f012eb0e4bca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Interwiki
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
