jenkins-bot has submitted this change and it was merged.
Change subject: Fix false Namespaceselector value for "all" on
Special:LinkSearch
......................................................................
Fix false Namespaceselector value for "all" on Special:LinkSearch
Added the ability to define the value in HTMLSelectNamespace.
Bug: T98496
Follow-Up: I8503c391a40f1654f8570578a9de9015d86c9845
Change-Id: Ic6a871507a027d28b3aeb1efeb9abbceb5734a9e
---
M includes/htmlform/HTMLSelectNamespace.php
M includes/specials/SpecialLinkSearch.php
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/htmlform/HTMLSelectNamespace.php
b/includes/htmlform/HTMLSelectNamespace.php
index 9638106..b2ec9ca 100644
--- a/includes/htmlform/HTMLSelectNamespace.php
+++ b/includes/htmlform/HTMLSelectNamespace.php
@@ -4,10 +4,12 @@
*/
class HTMLSelectNamespace extends HTMLFormField {
function getInputHTML( $value ) {
+ $allValue = ( isset( $this->mParams['all'] ) ?
$this->mParams['all'] : 'all' );
+
return Html::namespaceSelector(
array(
'selected' => $value,
- 'all' => 'all'
+ 'all' => $allValue
), array(
'name' => $this->mName,
'id' => $this->mID,
diff --git a/includes/specials/SpecialLinkSearch.php
b/includes/specials/SpecialLinkSearch.php
index 0c02628..f5218ac 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -140,6 +140,7 @@
'label-message' => 'linksearch-ns',
'default' => $namespace,
'id' => 'namespace',
+ 'all' => '',
'cssclass' => 'namespaceselector',
),
);
--
To view, visit https://gerrit.wikimedia.org/r/209517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6a871507a027d28b3aeb1efeb9abbceb5734a9e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
