jenkins-bot has submitted this change and it was merged.

Change subject: Explicitly define module position
......................................................................


Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: Idd6d26f71dace8b04491652f112eba4aa9dc2123
---
M TimedMediaHandler.hooks.php
M TimedMediaHandler_body.php
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index bc7d7cb..3e4cfbf 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -64,8 +64,11 @@
                $wgResourceModules+= array(
                        'mw.PopUpMediaTransform' => $baseExtensionResource + 
array(
                                'scripts' => 'resources/mw.PopUpThumbVideo.js',
-                               'styles' => 'resources/PopUpThumbVideo.css',
                                'dependencies' => array( 'mw.MwEmbedSupport', 
'mediawiki.Title' ),
+                       ),
+                       'mw.PopUpMediaTransform.styles' => 
$baseExtensionResource + array(
+                               'position' => 'top',
+                               'styles' => 'resources/PopUpThumbVideo.css',
                        ),
                        'mw.TMHGalleryHook.js' => $baseExtensionResource + 
array(
                                'scripts' => 'resources/mw.TMHGalleryHook.js',
@@ -405,7 +408,7 @@
 
                if ( $addModules ) {
                        $out->addModuleScripts( 'mw.PopUpMediaTransform' );
-                       $out->addModuleStyles( 'mw.PopUpMediaTransform' );
+                       $out->addModuleStyles( 'mw.PopUpMediaTransform.styles' 
);
                }
 
                return true;
diff --git a/TimedMediaHandler_body.php b/TimedMediaHandler_body.php
index 9bd172a..28a7009 100644
--- a/TimedMediaHandler_body.php
+++ b/TimedMediaHandler_body.php
@@ -215,7 +215,7 @@
        static function outputHook( $outputPage, $parserOutput, $data ) {
                // Add the PopUpMediaTransform code
                $outputPage->addModuleScripts( 'mw.PopUpMediaTransform' );
-               $outputPage->addModuleStyles( 'mw.PopUpMediaTransform' );
+               $outputPage->addModuleStyles( 'mw.PopUpMediaTransform.styles' );
                $outputPage->addModules( 'mw.TMHGalleryHook.js' );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/208974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd6d26f71dace8b04491652f112eba4aa9dc2123
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to