Isarra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213292
Change subject: Convert extension registration to use skin.json
......................................................................
Convert extension registration to use skin.json
Change-Id: I55af1ebf6499795c8cc0f7f447e8d43114aa4ef4
---
M Truglass.php
A skin.json
2 files changed, 54 insertions(+), 32 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Truglass
refs/changes/92/213292/1
diff --git a/Truglass.php b/Truglass.php
index 54eb83a..bce32c3 100644
--- a/Truglass.php
+++ b/Truglass.php
@@ -16,37 +16,18 @@
* require_once("$IP/skins/Truglass/Truglass.php");
*/
-if( !defined( 'MEDIAWIKI' ) ) {
- die( 'Not a valid entry point.' );
+if ( function_exists( 'wfLoadSkin' ) ) {
+ wfLoadSkin( 'Truglass' );
+ // Keep i18n globals so mergeMessageFileList.php doesn't break
+ $wgMessagesDirs['Truglass'] = __DIR__ . '/i18n';
+ $wgExtensionMessagesFiles['Truglass'] = __DIR__ . '/Truglass.alias.php';
+ wfWarn(
+ 'Deprecated PHP entry point used for Truglass skin. Please use
wfLoadSkin instead, ' .
+ 'see https://www.mediawiki.org/wiki/Extension_registration for
more details.'
+ );
+ return;
+} else {
+ die( 'This version of the Truglass skin requires MediaWiki 1.25+' );
}
-// Skin credits that will show up on Special:Version
-$wgExtensionCredits['skin'][] = array(
- 'path' => __FILE__,
- 'name' => 'Truglass',
- 'version' => '3.1.1',
- 'author' => array( 'Elliott Franklin Cable', 'Jack Phoenix' ),
- 'description' => 'A sleek, stylish, simplified skin',
- 'url' => 'https://www.mediawiki.org/wiki/Skin:Truglass',
-);
-
-// The first instance must be strtolower()ed so that useskin=truglass works and
-// so that it does *not* force an initial capital (i.e. we do NOT want
-// useskin=Truglass) and the second instance is used to determine the name of
-// *this* file.
-$wgValidSkinNames['truglass'] = 'Truglass';
-
-// Autoload the skin class, make it a valid skin, set up i18n, set up CSS
-// (via ResourceLoader)
-$wgAutoloadClasses['SkinTruglass'] = __DIR__ . '/Truglass.skin.php';
-$wgConfigRegistry['truglass'] = 'GlobalVarConfig::newInstance';
-$wgMessagesDirs['SkinTruglass'] = __DIR__ . '/i18n';
-$wgResourceModules['skins.truglass'] = array(
- 'styles' => array(
- 'skins/Truglass/truglass/main.css' => array( 'media' =>
'screen' ),
- 'skins/Truglass/truglass/handheld.css' => array( 'media' =>
'handheld' ),
- ),
- 'position' => 'top'
-);
-
-$wgTruglassSidebarLinks = array();
\ No newline at end of file
+$wgTruglassSidebarLinks = array();
diff --git a/skin.json b/skin.json
new file mode 100644
index 0000000..e9704ed
--- /dev/null
+++ b/skin.json
@@ -0,0 +1,41 @@
+{
+ "name": "Truglass",
+ "version": "3.1.2",
+ "author": [
+ "Elliott Franklin Cable",
+ "Jack Phoenix"
+ ],
+ "url": "https://www.mediawiki.org/wiki/Skin:Truglass";,
+ "description": "A sleek, stylish, simplified skin",
+ "type": "skin",
+ "ConfigRegistry": {
+ "truglass": "GlobalVarConfig::newInstance"
+ },
+ "ValidSkinNames": {
+ "truglass": "Truglass"
+ },
+ "MessagesDirs": {
+ "SkinTruglass": [
+ "i18n"
+ ]
+ },
+ "AutoloadClasses": {
+ "SkinTruglass": "Truglass.skin.php"
+ },
+ "ResourceModules": {
+ "skins.truglass": {
+ "styles": {
+ "skins/Truglass/truglass/main.css": {
+ "media": "screen"
+ },
+ "skins/Truglass/truglass/handheld.css": {
+ "media": "handheld"
+ }
+ },
+ "position": "top"
+ }
+ },
+ "config": {
+ "TruglassSidebarLinks": []
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/213292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55af1ebf6499795c8cc0f7f447e8d43114aa4ef4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: Isarra <zhoris...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
