jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Fixing broken test for Page Options test The test was broken as some identifiers were wrong. Updated it. ......................................................................
[BrowserTest] Fixing broken test for Page Options test The test was broken as some identifiers were wrong. Updated it. Change-Id: I03541e4ae0ed7e4c121b801a036e49bebe4d5909 --- M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dduvall: Looks good to me, approved Etonkovidova: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 8ff9153..a784360 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -46,12 +46,12 @@ div(:content, class: 've-ce-branchNode') span(:decrease_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-outdent') text_area(:describe_change, index: 0) - table(:diff_view, css: '.ve-ui-mwSaveDialog-viewer table.diff') + div(:diff_view, class: 've-ui-mwSaveDialog-viewer') div(:disabled_save_button, css: 'div.ve-init-mw-viewPageTarget-toolbar .oo-ui-toolbar-actions > div.oo-ui-flaggedElement-progressive.oo-ui-widget-disabled') text_field(:display_title_textbox, css: 'div.oo-ui-fieldLayout-align-inline:nth-child(4) > label:nth-child(1) > div:nth-child(1) > div:nth-child(1) > input:nth-child(1)') div(:enable_redirect, class: 've-test-page-settings-enable-redirect') div(:prevent_redirect, class: 've-test-page-settings-prevent-redirect') - text_field(:redirect_page_name_textbox, css: '.oo-ui-flaggedElement-invalid > input:nth-child(1)') + text_field(:redirect_page_name_textbox, css: 'div.oo-ui-lookupElement:nth-child(1) > input:nth-child(1)') div(:format_indicator, class: 've-test-toolbar-format') span(:format_indicator_down, css: '.ve-test-toolbar-format .oo-ui-indicator-down') a(:edit_ve, title: /Edit this page with VisualEditor/) -- To view, visit https://gerrit.wikimedia.org/r/213343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03541e4ae0ed7e4c121b801a036e49bebe4d5909 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ryasmeen <ryasm...@wikimedia.org> Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org> Gerrit-Reviewer: Etonkovidova <etonkovid...@wikimedia.org> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
